From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH retry] arch/ia64/kvm/kvm-ia64.c: Add local_irq_restore
 in error handling code
Date: Sat, 26 Jul 2008 12:10:01 +0300
Message-ID: <488AE9E9.1020502@qumranet.com>
References: <Pine.LNX.4.64.0807222137350.2670@ask.diku.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, xiantao.zhang@intel.com,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
To: Julia Lawall <julia@diku.dk>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:50620 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751330AbYGZJKD (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 26 Jul 2008 05:10:03 -0400
In-Reply-To: <Pine.LNX.4.64.0807222137350.2670@ask.diku.dk>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> There is a call to local_irq_restore in the normal exit case, so it would
> seem that there should be one on an error return as well.
>
> The semantic patch that finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>   

Applied, thanks.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.