From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH 2/9] kvm: qemu: Fix virtio_net tx timer
Date: Sat, 26 Jul 2008 12:48:28 +0300
Message-ID: <488AF2EC.5050301@qumranet.com>
References: <1216899979-32532-1-git-send-email-markmc@redhat.com> <1216899979-32532-2-git-send-email-markmc@redhat.com> <1216899979-32532-3-git-send-email-markmc@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>,
	Rusty Russell <rusty@rustcorp.com.au>
To: Mark McLoughlin <markmc@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:51594 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751447AbYGZJsa (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 26 Jul 2008 05:48:30 -0400
In-Reply-To: <1216899979-32532-3-git-send-email-markmc@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Mark McLoughlin wrote:
> The current virtio_net tx timer is 2ns, which doesn't
> make any sense. Set it to a more reasonable 150us
> instead.
>
> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
> ---
>  qemu/hw/virtio-net.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu/hw/virtio-net.c b/qemu/hw/virtio-net.c
> index 2e57e5a..31867f1 100644
> --- a/qemu/hw/virtio-net.c
> +++ b/qemu/hw/virtio-net.c
> @@ -26,7 +26,7 @@
>  #define VIRTIO_NET_F_MAC	5
>  #define VIRTIO_NET_F_GS0	6
>  
> -#define TX_TIMER_INTERVAL (1000 / 500)
> +#define TX_TIMER_INTERVAL (150000) /* 150 us */
>  
>   

Ouch.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.