Re: [Qemu-devel] [PATCH]: Fix i2c_bus_save, which fixes KVM live migration

andrzej zaborowski
2008-07-29T18:35:59Z

2008/7/29 Paul Brook <paul@codesourcery.com>:
> On Tuesday 29 July 2008, andrzej zaborowski wrote:
>> 2008/7/29 Chris Lalancette <clalance@redhat.com>:
>> > Attached is a simple patch to make i2c_bus_save() put a 32-bit quantity
>> > in the save file, which matches what i2c_bus_load() expects to pull out
>> > of the save file later. Without this fix in place, KVM live migration
>> > fails since the sender is only sending 1 byte while the receiver is
>> > waiting to receive 4 bytes.
>>
>> Thanks, I committed this modified to use byte width afterall since the
>> addresses are 7-bit quantities.
>
> No they aren't. I2C also supports 10-bit addressing.

Addresses in qemu are still <= 8-bit, for example i2c_slave_load()
assumes this and current i2c api users do.

Regards