From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] kvm-userspace: fix memslot assignment
Date: Tue, 29 Jul 2008 16:18:49 +0300
Message-ID: <488F18B9.1010700@qumranet.com>
References: <200807251738.29171.borntraeger@de.ibm.com> <488C2F52.4030209@qumranet.com> <200807281855.04681.borntraeger@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm <kvm@vger.kernel.org>, Carsten Otte <cotte@de.ibm.com>,
	Olaf Schnapper <os@de.ibm.com>,
	Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:19642 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753470AbYG2NSv (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 29 Jul 2008 09:18:51 -0400
In-Reply-To: <200807281855.04681.borntraeger@de.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Christian Borntraeger wrote:
> Am Sonntag, 27. Juli 2008 schrieb Avi Kivity:
>   
>> This is really a no-op, since s390 will nack a KVM_CAP_SET_TSS_ADDR 
>> query.  Of course, the change is an improvement.
>>
>>     
>>> @@ -92,8 +92,11 @@ int get_free_slot(kvm_context_t kvm)
>>>  	if (tss_ext > 0)
>>>  		i = 0;
>>>  	else
>>> +#if !defined(__s390__)
>>>  		i = 1;
>>> -
>>> +#else
>>> +		i = 0;
>>> +#endif
>>>   
>>>       
>> ppc and ia64 also don't care about TSS_ADDR.  Care to make this depend 
>> on x86, rather than on s390?
>>     
>
> Can do. Should ppc and ia64 start with i=1 or i=0, do they need a reserved 
> slot?
>
>   

They all start with 0 AFAIK (kvm also starts with 0, it just wants it to 
be a special slot).

-- 
error compiling committee.c: too many arguments to function