From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH]: Fix i2c_bus_save, which fixes KVM live migration Date: Tue, 29 Jul 2008 13:38:54 -0500 Message-ID: <488F63BE.5060804@codemonkey.ws> References: <488EBEFC.5040603@redhat.com> <200807291918.55451.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Paul Brook , qemu-devel@nongnu.org, kvm@vger.kernel.org To: andrzej zaborowski Return-path: Received: from wr-out-0506.google.com ([64.233.184.232]:9180 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753282AbYG2Sjs (ORCPT ); Tue, 29 Jul 2008 14:39:48 -0400 Received: by wr-out-0506.google.com with SMTP id 69so1861wri.5 for ; Tue, 29 Jul 2008 11:39:47 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: andrzej zaborowski wrote: > 2008/7/29 Paul Brook : > >> No they aren't. I2C also supports 10-bit addressing. >> > > Addresses in qemu are still <= 8-bit, for example i2c_slave_load() > assumes this and current i2c api users do. > But for the save/restore format, if the spec can support 10-bit addressing, then we should use be16s to avoid having to change save/restore format if we ever expand the supported address size. Regards, Anthony Liguori > Regards > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >