public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATH] kvm-72 - fix compilation on 2.6.26 (anon_inode_getfd flag)
@ 2008-07-29  8:55 Nikola Ciprich
  2008-07-29 20:26 ` Bill Davidsen
  0 siblings, 1 reply; 6+ messages in thread
From: Nikola Ciprich @ 2008-07-29  8:55 UTC (permalink / raw)
  To: KVM list; +Cc: nikola.ciprich

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi,
anon_inode_getfd flag parameter was added after 2.6.26
following patch fixes compilation
please apply
thanks
nik

-- 
-------------------------------------
Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799
www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz
-------------------------------------

[-- Attachment #2: kvm-72-fix-2.6.26-anon-inode.diff --]
[-- Type: text/plain, Size: 559 bytes --]

diff -Naur kvm-72/kernel/anon_inodes.c kvm-72-fix-2.6.26-anon-inode/kernel/anon_inodes.c
--- kvm-72/kernel/anon_inodes.c	2008-07-27 12:08:56.000000000 +0200
+++ kvm-72-fix-2.6.26-anon-inode/kernel/anon_inodes.c	2008-07-29 10:36:51.000000000 +0200
@@ -245,6 +245,15 @@
 	return fd;
 }
 
+#elif LINUX_VERSION_CODE == KERNEL_VERSION(2,6,26)
+
+int kvm_anon_inode_getfd(const char *name,
+			 const struct file_operations *fops,
+			 void *priv, int flags)
+{
+	return anon_inode_getfd(name, fops, priv);
+}
+
 #else
 
 int kvm_anon_inode_getfd(const char *name,

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATH] kvm-72 - fix compilation on 2.6.26 (anon_inode_getfd flag)
  2008-07-29  8:55 [PATH] kvm-72 - fix compilation on 2.6.26 (anon_inode_getfd flag) Nikola Ciprich
@ 2008-07-29 20:26 ` Bill Davidsen
  2008-07-29 20:49   ` Nikola Ciprich
  0 siblings, 1 reply; 6+ messages in thread
From: Bill Davidsen @ 2008-07-29 20:26 UTC (permalink / raw)
  To: Nikola Ciprich; +Cc: KVM list, nikola.ciprich

Nikola Ciprich wrote:
> Hi,
> anon_inode_getfd flag parameter was added after 2.6.26
> following patch fixes compilation
> please apply
> thanks
> nik
> 
> 
> 
> ------------------------------------------------------------------------
> 
> diff -Naur kvm-72/kernel/anon_inodes.c kvm-72-fix-2.6.26-anon-inode/kernel/anon_inodes.c
> --- kvm-72/kernel/anon_inodes.c	2008-07-27 12:08:56.000000000 +0200
> +++ kvm-72-fix-2.6.26-anon-inode/kernel/anon_inodes.c	2008-07-29 10:36:51.000000000 +0200
> @@ -245,6 +245,15 @@
>  	return fd;
>  }
>  
> +#elif LINUX_VERSION_CODE == KERNEL_VERSION(2,6,26)

Should that be ">=" for future use?

> +
> +int kvm_anon_inode_getfd(const char *name,
> +			 const struct file_operations *fops,
> +			 void *priv, int flags)
> +{
> +	return anon_inode_getfd(name, fops, priv);
> +}
> +
>  #else
>  
>  int kvm_anon_inode_getfd(const char *name,


-- 
Bill Davidsen <davidsen@tmr.com>
   "We have more to fear from the bungling of the incompetent than from
the machinations of the wicked."  - from Slashdot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATH] kvm-72 - fix compilation on 2.6.26 (anon_inode_getfd flag)
  2008-07-29 20:26 ` Bill Davidsen
@ 2008-07-29 20:49   ` Nikola Ciprich
  2008-07-30 14:34     ` Avi Kivity
  0 siblings, 1 reply; 6+ messages in thread
From: Nikola Ciprich @ 2008-07-29 20:49 UTC (permalink / raw)
  To: Bill Davidsen; +Cc: KVM list, nikola.ciprich

> Should that be ">=" for future use?
nope, newer versions have also the flag parameter (see 2.6.27-rcX), so this is intended only for 2.6.26


-- 
-------------------------------------
Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799

www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz
-------------------------------------

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATH] kvm-72 - fix compilation on 2.6.26 (anon_inode_getfd flag)
  2008-07-29 20:49   ` Nikola Ciprich
@ 2008-07-30 14:34     ` Avi Kivity
  2008-07-30 16:10       ` Nikola Ciprich
  0 siblings, 1 reply; 6+ messages in thread
From: Avi Kivity @ 2008-07-30 14:34 UTC (permalink / raw)
  To: Nikola Ciprich; +Cc: Bill Davidsen, KVM list, nikola.ciprich

Nikola Ciprich wrote:
>> Should that be ">=" for future use?
>>     
> nope, newer versions have also the flag parameter (see 2.6.27-rcX), so this is intended only for 2.6.26
>
>   

Please resend the patch as I don't have it in my mailbox.

-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATH] kvm-72 - fix compilation on 2.6.26 (anon_inode_getfd flag)
  2008-07-30 14:34     ` Avi Kivity
@ 2008-07-30 16:10       ` Nikola Ciprich
  2008-07-31 10:56         ` Avi Kivity
  0 siblings, 1 reply; 6+ messages in thread
From: Nikola Ciprich @ 2008-07-30 16:10 UTC (permalink / raw)
  To: Avi Kivity; +Cc: Nikola Ciprich, Bill Davidsen, KVM list

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

Hi, sure.
hope it's OK
n.
PS: I mean't PATCH, not PATH of course. Although it was quite a long path to patch :)

On Wed, Jul 30, 2008 at 05:34:14PM +0300, Avi Kivity wrote:
> Nikola Ciprich wrote:
>>> Should that be ">=" for future use?
>>>     
>> nope, newer versions have also the flag parameter (see 2.6.27-rcX), so this is intended only for 2.6.26
>>
>>   
>
> Please resend the patch as I don't have it in my mailbox.
>
> -- 
> error compiling committee.c: too many arguments to function
>

-- 
-------------------------------------
Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799

www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz
-------------------------------------

[-- Attachment #2: kvm-72-fix-2.6.26-anon-inode.diff --]
[-- Type: text/plain, Size: 559 bytes --]

diff -Naur kvm-72/kernel/anon_inodes.c kvm-72-fix-2.6.26-anon-inode/kernel/anon_inodes.c
--- kvm-72/kernel/anon_inodes.c	2008-07-27 12:08:56.000000000 +0200
+++ kvm-72-fix-2.6.26-anon-inode/kernel/anon_inodes.c	2008-07-29 10:36:51.000000000 +0200
@@ -245,6 +245,15 @@
 	return fd;
 }
 
+#elif LINUX_VERSION_CODE == KERNEL_VERSION(2,6,26)
+
+int kvm_anon_inode_getfd(const char *name,
+			 const struct file_operations *fops,
+			 void *priv, int flags)
+{
+	return anon_inode_getfd(name, fops, priv);
+}
+
 #else
 
 int kvm_anon_inode_getfd(const char *name,

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATH] kvm-72 - fix compilation on 2.6.26 (anon_inode_getfd flag)
  2008-07-30 16:10       ` Nikola Ciprich
@ 2008-07-31 10:56         ` Avi Kivity
  0 siblings, 0 replies; 6+ messages in thread
From: Avi Kivity @ 2008-07-31 10:56 UTC (permalink / raw)
  To: Nikola Ciprich; +Cc: Nikola Ciprich, Bill Davidsen, KVM list

Nikola Ciprich wrote:
> Hi, sure.
> hope it's OK
>   

Applied, thanks.  Please signoff in the future.

-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2008-07-31 10:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-29  8:55 [PATH] kvm-72 - fix compilation on 2.6.26 (anon_inode_getfd flag) Nikola Ciprich
2008-07-29 20:26 ` Bill Davidsen
2008-07-29 20:49   ` Nikola Ciprich
2008-07-30 14:34     ` Avi Kivity
2008-07-30 16:10       ` Nikola Ciprich
2008-07-31 10:56         ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox