From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: bios: Put AP boot up code to 0x1000 Date: Thu, 31 Jul 2008 12:46:08 +0300 Message-ID: <489189E0.8070804@qumranet.com> References: <200807311043.20880.sheng.yang@intel.com> <200807311400.11644.sheng.yang@intel.com> <48915E80.8010406@qumranet.com> <200807311709.29198.sheng.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: "Yang, Sheng" Return-path: Received: from il.qumranet.com ([212.179.150.194]:26325 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753210AbYGaJqK (ORCPT ); Thu, 31 Jul 2008 05:46:10 -0400 In-Reply-To: <200807311709.29198.sheng.yang@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Yang, Sheng wrote: > On Thursday 31 July 2008 14:41:04 Avi Kivity wrote: > >> Yang, Sheng wrote: >> >>> On Thursday 31 July 2008 10:43:20 Yang, Sheng wrote: >>> >>>> From ba05b3c821400127074f65ee4d172fabbe3524cd Mon Sep 17 >>>> 00:00:00 2001 From: Sheng Yang >>>> Date: Thu, 31 Jul 2008 10:39:24 +0800 >>>> Subject: [PATCH] kvm: bios: Put AP boot up code to 0x1000 >>>> >>>> Rather than 0x10000, which can be overrided by userspace program >>>> like grub. >>>> >> How about 0xex000? And avoid copying the bios to low memory? >> >> Gleb tried it and it worked. We'd have to change qemu to mark the >> memory as RAM, not ROM, but that's what real hardware does as well >> (shadowing the ROM into RAM). >> > > I tried 0xea000, and it's fine. But avoid copying is better. > > But I don't understand the RAM/ROM issue in qemu here... > IIRC the rombios32.c writes to the memory it is in, so it expects RAM, not ROM. kvm doesn't support ROM, so it would work. Qemu doesn't, so it would fail. > And do you mean you have patch on hand now? :) > > No, but maybe Gleb does. -- error compiling committee.c: too many arguments to function