From: Avi Kivity <avi@qumranet.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: kvm <kvm@vger.kernel.org>, Carsten Otte <cotte@de.ibm.com>,
Olaf Schnapper <os@de.ibm.com>,
Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>,
Izik Eidus <izike@qumranet.com>
Subject: Re: [PATCH] kvm-userspace: fix memslot assignment
Date: Thu, 31 Jul 2008 14:24:13 +0300 [thread overview]
Message-ID: <4891A0DD.5000503@qumranet.com> (raw)
In-Reply-To: <200807311001.07426.borntraeger@de.ibm.com>
Christian Borntraeger wrote:
> Am Dienstag, 29. Juli 2008 schrieb Avi Kivity:
>
>> They all start with 0 AFAIK (kvm also starts with 0, it just wants it to
>> be a special slot).
>>
>
> Now my brain hurts....
> Ok, so I read this as: ppc, ia64 and s390 can start with slot 0 and it is not a special slot.
> On x86 slot 0 is special, if
> * KVM_CAP_SET_TSS_ADDR is not available
> or
> * The ioctl VM_CAP_SET_TSS_ADDR returns <=0
>
>
I think this is right. Izik can you confirm?
> +#if defined(__x86_64__) || defined(__i386__)
> +#if defined(KVM_CAP_SET_TSS_ADDR)
> + if (ioctl(kvm->fd, KVM_CHECK_EXTENSION, KVM_CAP_SET_TSS_ADDR) > 0)
>
Should be <= here?
> + i++;
> +#else
> + i++;
> +#endif
> +#endif
>
Suggest a helper, kvm_supports_set_tss_addr(), to reduce further
braindamage.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-07-31 11:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 15:38 [PATCH] kvm-userspace: fix memslot assignment Christian Borntraeger
2008-07-27 8:18 ` Avi Kivity
2008-07-28 16:55 ` Christian Borntraeger
2008-07-29 13:18 ` Avi Kivity
2008-07-31 8:01 ` Christian Borntraeger
2008-07-31 11:24 ` Avi Kivity [this message]
2008-07-31 12:03 ` Izik Eidos
2008-07-31 12:53 ` Christian Borntraeger
2008-07-31 13:00 ` Avi Kivity
2008-07-31 14:57 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4891A0DD.5000503@qumranet.com \
--to=avi@qumranet.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=ehrhardt@linux.vnet.ibm.com \
--cc=izike@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=os@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox