From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] kvm-userspace: fix memslot assignment
Date: Thu, 31 Jul 2008 16:00:27 +0300
Message-ID: <4891B76B.5090009@qumranet.com>
References: <200807251738.29171.borntraeger@de.ibm.com> <200807311001.07426.borntraeger@de.ibm.com> <4891A0DD.5000503@qumranet.com> <200807311453.56210.borntraeger@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm <kvm@vger.kernel.org>, Carsten Otte <cotte@de.ibm.com>,
	Olaf Schnapper <os@de.ibm.com>,
	Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>,
	Izik Eidus <izike@qumranet.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:16218 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751530AbYGaNA3 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 31 Jul 2008 09:00:29 -0400
In-Reply-To: <200807311453.56210.borntraeger@de.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Christian Borntraeger wrote:
> Something like that? But then I get the following warning on non-x86:
> libkvm.c:77: warning: 'kvm_supports_set_tss_addr' defined but not used
>
> Should I mask the wrapper with config x86 as well?
>   

If we rename the helper, kvm_wants_special_memslot_0() (reversing the 
meaning), we can have non-x86 return 0, x86 with KVM_CAP_SET_TSS_ADDR 
return  0, and otherwise return 1.  No ifdefs outside the helper this way.

>
> ---
>  libkvm.c |   32 +++++++++++++++++---------------
>  1 file changed, 17 insertions(+), 15 deletions(-)
>   
(missing signoff)


-- 
error compiling committee.c: too many arguments to function