From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: e1000 PXE breakage bisected down in kvm-userspace Date: Mon, 04 Aug 2008 16:43:21 -0500 Message-ID: <489777F9.1080404@codemonkey.ws> References: <4897706A.8010206@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Charles Duffy Return-path: Received: from an-out-0708.google.com ([209.85.132.247]:7097 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1771186AbYHDVn6 (ORCPT ); Mon, 4 Aug 2008 17:43:58 -0400 Received: by an-out-0708.google.com with SMTP id d40so359579and.103 for ; Mon, 04 Aug 2008 14:43:57 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Charles Duffy wrote: > Anthony Liguori wrote: >> Charles Duffy wrote: >>> Per subject. "git bisect run" script (and libvirt xml helper) attached. >> >> Does the problem go away if you make the e1000_can_receive() function >> always return 1? > > Yes. Presumably, this is the proper fix. Can you verify? diff --git a/qemu/hw/e1000.c b/qemu/hw/e1000.c index 1be69ec..6a07b0c 100644 --- a/qemu/hw/e1000.c +++ b/qemu/hw/e1000.c @@ -521,8 +521,8 @@ e1000_can_receive(void *opaque) { E1000State *s = opaque; - return ((s->mac_reg[RCTL] & E1000_RCTL_EN) && - s->mac_reg[RDH] != s->mac_reg[RDT]); + return (!(s->mac_reg[RCTL] & E1000_RCTL_EN) || + s->mac_reg[RDH] != s->mac_reg[RDT]); } static void Regards, Anthony Liguori > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html