From: Anthony Liguori <anthony@codemonkey.ws>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Avi Kivity <avi@qumranet.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 0/12] virtio_net perf patches
Date: Mon, 11 Aug 2008 15:30:10 -0500 [thread overview]
Message-ID: <48A0A152.6070405@codemonkey.ws> (raw)
In-Reply-To: <1218485535-877-1-git-send-email-markmc@redhat.com>
Mark McLoughlin wrote:
> Hi Avi,
> Here's the set of patches that I think make sense to apply.
>
We probably need to disable checksum offload on the RX side until we
figure out what to do about the broken dhclient. That's going to hit a
lot of users otherwise.
Regards,
Anthony Liguori
> I've left out Anthony's zero-copy patch since I wasn't seeing
> a measurable difference with it, it's quite invasive and isn't safe
> with the "drop the global mutex during tapfd read()" patch.
>
> I left that mutex patch 'til last since you may still be
> nervous about concurrency issues and also the posix-timers kernel race
> that it triggers.
>
> Another change since the first round of patches is that it
> took a bit of ugly hackery to handle the case where IFF_VNET_HDR
> is supported and we're using e.g. e1000. Since it's difficult to
> only enable IFF_VNET_HDR when we're using virtio_net_hdr, I went with
> this approach.
>
> Lastly, I need to add a "vnet_hdr=on" param to "-net tap" so
> that we can know if the supplied tap fd has IFF_VNET_HDR enabled.
> There's no interface to query that on the fd right now, and even if
> I did cook up a patch it probably wouldn't make 2.6.27.
>
> Cheers,
> Mark.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2008-08-11 20:30 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 20:12 [PATCH 0/12] virtio_net perf patches Mark McLoughlin
2008-08-11 20:12 ` [PATCH 01/12] kvm: qemu: Fix virtio_net tx timer Mark McLoughlin
2008-08-11 20:12 ` [PATCH 02/12] kvm: qemu: Remove virtio_net tx ring-full heuristic Mark McLoughlin
2008-08-11 20:12 ` [PATCH 03/12] kvm: qemu: Add VIRTIO_F_NOTIFY_ON_EMPTY Mark McLoughlin
2008-08-11 20:12 ` [PATCH 04/12] kvm: qemu: Disable recv notifications until avail buffers exhausted Mark McLoughlin
2008-08-11 20:12 ` [PATCH 05/12] kvm: qemu: Add support for partial csums and GSO Mark McLoughlin
2008-08-11 20:12 ` [PATCH 06/12] kvm: qemu: Rename tap_readv() to tap_receive_iov() Mark McLoughlin
2008-08-11 20:12 ` [PATCH 07/12] kvm: qemu: Move some code around for the next commit Mark McLoughlin
2008-08-11 20:12 ` [PATCH 08/12] kvm: qemu: Don't require all drivers to use virtio_net_hdr Mark McLoughlin
2008-08-11 20:12 ` [PATCH 09/12] kvm: qemu: Actually enable GSO support Mark McLoughlin
2008-08-11 20:12 ` [PATCH 10/12] kvm: qemu: Add a -net tap,fd=X,vnet_hdr=on option Mark McLoughlin
2008-08-11 20:12 ` [PATCH 11/12] kvm: qemu: Increase size of virtio_net rings Mark McLoughlin
2008-08-11 20:12 ` [PATCH 12/12] kvm: qemu: Drop the mutex while reading from tapfd Mark McLoughlin
2008-08-11 20:30 ` [PATCH 10/12] kvm: qemu: Add a -net tap,fd=X,vnet_hdr=on option Anthony Liguori
2008-08-12 17:41 ` [PATCH 08/12] kvm: qemu: Don't require all drivers to use virtio_net_hdr Mark McLoughlin
2008-08-13 9:13 ` Avi Kivity
2008-08-11 20:30 ` Anthony Liguori [this message]
2008-08-12 18:12 ` [PATCH 0/12] virtio_net perf patches Mark McLoughlin
2008-08-12 18:28 ` Anthony Liguori
2008-08-12 23:39 ` Herbert Xu
2008-08-12 13:51 ` Avi Kivity
2008-08-12 14:55 ` Avi Kivity
2008-08-13 14:39 ` [PATCH 1/1] kvm: qemu: Handle tap fds with IFF_VNET_HDR Mark McLoughlin
2008-08-13 16:24 ` Avi Kivity
2008-08-13 16:28 ` Daniel P. Berrange
2008-08-20 17:04 ` [PATCH] " Mark McLoughlin
2008-08-20 17:09 ` Mark McLoughlin
2008-08-20 17:27 ` Avi Kivity
2008-08-20 17:49 ` Anthony Liguori
2008-08-20 17:51 ` Avi Kivity
2008-08-20 18:01 ` Anthony Liguori
2008-08-21 9:30 ` Mark McLoughlin
2008-08-21 13:55 ` Avi Kivity
2008-08-21 13:58 ` Anthony Liguori
2008-08-20 18:11 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A0A152.6070405@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox