From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 0/12] virtio_net perf patches Date: Mon, 11 Aug 2008 15:30:10 -0500 Message-ID: <48A0A152.6070405@codemonkey.ws> References: <1218485535-877-1-git-send-email-markmc@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from wr-out-0506.google.com ([64.233.184.233]:46345 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752093AbYHKUa5 (ORCPT ); Mon, 11 Aug 2008 16:30:57 -0400 Received: by wr-out-0506.google.com with SMTP id 69so1541507wri.5 for ; Mon, 11 Aug 2008 13:30:57 -0700 (PDT) In-Reply-To: <1218485535-877-1-git-send-email-markmc@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > Hi Avi, > Here's the set of patches that I think make sense to apply. > We probably need to disable checksum offload on the RX side until we figure out what to do about the broken dhclient. That's going to hit a lot of users otherwise. Regards, Anthony Liguori > I've left out Anthony's zero-copy patch since I wasn't seeing > a measurable difference with it, it's quite invasive and isn't safe > with the "drop the global mutex during tapfd read()" patch. > > I left that mutex patch 'til last since you may still be > nervous about concurrency issues and also the posix-timers kernel race > that it triggers. > > Another change since the first round of patches is that it > took a bit of ugly hackery to handle the case where IFF_VNET_HDR > is supported and we're using e.g. e1000. Since it's difficult to > only enable IFF_VNET_HDR when we're using virtio_net_hdr, I went with > this approach. > > Lastly, I need to add a "vnet_hdr=on" param to "-net tap" so > that we can know if the supplied tap fd has IFF_VNET_HDR enabled. > There's no interface to query that on the fd right now, and even if > I did cook up a patch it probably wouldn't make 2.6.27. > > Cheers, > Mark. > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >