From: Avi Kivity <avi@qumranet.com>
To: Philippe Gerum <rpm@xenomai.org>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 4/4] Fix --disable-kvm build
Date: Wed, 13 Aug 2008 11:15:15 +0300 [thread overview]
Message-ID: <48A29813.2040507@qumranet.com> (raw)
In-Reply-To: <1218567864-20346-5-git-send-email-rpm@xenomai.org>
Philippe Gerum wrote:
> static void vga_map(PCIDevice *pci_dev, int region_num,
> uint32_t addr, uint32_t size, int type)
> diff --git a/qemu/qemu-kvm.h b/qemu/qemu-kvm.h
> index 7e28428..9ba81a3 100644
> --- a/qemu/qemu-kvm.h
> +++ b/qemu/qemu-kvm.h
> @@ -114,6 +114,10 @@ extern kvm_context_t kvm_context;
> #define kvm_enabled() (0)
> #define qemu_kvm_irqchip_in_kernel() (0)
> #define qemu_kvm_pit_in_kernel() (0)
> +#define qemu_kvm_cpu_env(cpu) ({ (void)cpu; NULL; })
> +#define kvm_save_registers(cpu) do { (void)cpu; } while(0)
> +#define kvm_load_registers(env) do { (void)env; } while(0)
> +#define kvm_init_new_ap(cpu, env) do { (void)cpu; (void)env; } while(0)
> #endif
>
>
Please use static inline functions rather #defines, especially with
those statement expressions.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-08-13 8:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 19:04 [PATCH 0/4] Fix cpu-emulation mode builds Philippe Gerum
2008-08-12 19:04 ` [PATCH 1/4] Use proper open call for init file Philippe Gerum
2008-08-13 8:13 ` Avi Kivity
2008-08-13 14:17 ` Anthony Liguori
2008-08-13 14:25 ` Avi Kivity
2008-08-12 19:04 ` [PATCH 2/4] Provide dummy cpu_vendor_string Philippe Gerum
2008-08-13 8:16 ` Avi Kivity
2008-08-12 19:04 ` [PATCH 3/4] Fix dependencies to run dyngen early enough Philippe Gerum
2008-08-13 8:13 ` Avi Kivity
2008-08-12 19:04 ` [PATCH 4/4] Fix --disable-kvm build Philippe Gerum
2008-08-13 8:15 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A29813.2040507@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=rpm@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox