Re: [patch 0/2] do not run halted vcpu's

[Avi Kivity <avi@qumranet.com>]

Marcelo Tosatti wrote:
> Avi Kivity wrote:
>
>   
>> Any reason this is not in __vcpu_run()?
>>
>> Our main loop could look like
>>
>> while (no reason to stop)
>>       if (runnable)
>>            enter guest
>>       else
>>            block
>>       deal with aftermath
>>
>> kvm_emulate_halt would then simply modify the mp state.
>>     
>
> Like this?
>
> - I don't think it is necessary to test for pending signals inside irq
> safe section, so move that to exit processing.
>
>   


It is.  We may have received a signal after ioctl processing started but 
before entry.  If we don't don't check before entry, nothing ensures 
we'll ever exit (or we may exit due to some other reason, but the exit 
will be delayed).

> - Same for need_resched().
>
>   

Incorrect for the same reason.  There's no guarantee we will ever exit 
if we ignore the rescheduling IPI.

-- 
error compiling committee.c: too many arguments to function