From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 2/2] KVM: x86: do not execute halted vcpus (v2) Date: Wed, 13 Aug 2008 13:53:39 +0300 Message-ID: <48A2BD33.8080307@qumranet.com> References: <20080801230912.013317832@localhost.localdomain> <20080801231343.763237601@localhost.localdomain> <48A2BCAD.50005@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from il.qumranet.com ([212.179.150.194]:24609 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752734AbYHMKxk (ORCPT ); Wed, 13 Aug 2008 06:53:40 -0400 In-Reply-To: <48A2BCAD.50005@qumranet.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Marcelo Tosatti wrote: >> Offline or uninitialized vcpu's can be executed if requested to perform >> userspace work. >> Follow Avi's suggestion to handle halted vcpu's in the main loop, >> simplifying kvm_emulate_halt(). Introduce a new vcpu->requests bit to >> indicate events that promote state from halted to running. >> >> Also standardize vcpu wake sites. >> > > Apart from moving the entry checks to the exit, this looks fine (if > scary... this code is sensitive). > btw, this is a step forward for big real mode. We can later split the guest entry to have an emulation path if the guest state is not hardware friendly. -- error compiling committee.c: too many arguments to function