From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 6/9] move kvm_cpu_register_memory_area into qemu's Date: Wed, 13 Aug 2008 09:11:43 -0500 Message-ID: <48A2EB9F.6070009@us.ibm.com> References: <1218588489-17182-1-git-send-email-gcosta@redhat.com> <1218588489-17182-2-git-send-email-gcosta@redhat.com> <1218588489-17182-3-git-send-email-gcosta@redhat.com> <1218588489-17182-4-git-send-email-gcosta@redhat.com> <1218588489-17182-5-git-send-email-gcosta@redhat.com> <1218588489-17182-6-git-send-email-gcosta@redhat.com> <1218588489-17182-7-git-send-email-gcosta@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, avi@qumranet.com To: Glauber Costa Return-path: Received: from e35.co.us.ibm.com ([32.97.110.153]:34700 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752780AbYHMOMc (ORCPT ); Wed, 13 Aug 2008 10:12:32 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e35.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m7DECWLD006654 for ; Wed, 13 Aug 2008 10:12:32 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m7DECMIr061004 for ; Wed, 13 Aug 2008 08:12:25 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m7DECLN2004608 for ; Wed, 13 Aug 2008 08:12:21 -0600 In-Reply-To: <1218588489-17182-7-git-send-email-gcosta@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > Turn the explicit calls to kvm_cpu_register_memoy_area() > an empty function. Provide a __kvm_cpu_register_memory_area() > that is called from within cpu_register_memory_area(). > To avoid registering mmio regions to the hypervisor, since we depend on > them faulting, we keep track of what regions are mmio regions too. > > This is to be bisection friendly. Direct calls are to be removed > in a later commit. > > diff --git a/qemu/exec.c b/qemu/exec.c > index 7a68062..14c3852 100644 > --- a/qemu/exec.c > +++ b/qemu/exec.c > @@ -2196,6 +2196,9 @@ void cpu_register_physical_memory(target_phys_addr_t start_addr, > kqemu_set_phys_mem(start_addr, size, phys_offset); > } > #endif > + > + __kvm_cpu_register_physical_memory(start_addr, size, phys_offset); > > This is a great place to add a callback of some sort (like QEMUAccel). Then it can be shared by both kqemu and kvm. Regards, Anthony Liguori