From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Work around dhclient brokenness Date: Mon, 18 Aug 2008 14:40:55 +0300 Message-ID: <48A95FC7.90105@qumranet.com> References: <1218829632-19037-1-git-send-email-aliguori@us.ibm.com> <48A95579.6080004@qumranet.com> <20080818110116.GB19879@gondor.apana.org.au> <48A957C6.4050803@qumranet.com> <20080818113439.GA20219@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , kvm@vger.kernel.org, Mark McLoughlin , Rusty Russell To: Herbert Xu Return-path: Received: from il.qumranet.com ([212.179.150.194]:16258 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbYHRLk5 (ORCPT ); Mon, 18 Aug 2008 07:40:57 -0400 In-Reply-To: <20080818113439.GA20219@gondor.apana.org.au> Sender: kvm-owner@vger.kernel.org List-ID: Herbert Xu wrote: > On Mon, Aug 18, 2008 at 02:06:46PM +0300, Avi Kivity wrote: > >>> I still think that having the guests tell us that they can handle >>> it is the safest and most efficient way to proceed. >>> >>> >> I thought this is a userspace problem? Can we fix this in the guest kernel? >> > > Right, I meant that it's best to have the guest's user-space tell > us that it can handle checksum offload through ethtool via virtio. > Isn't that turned on automatically for real hardware? And what's to prevent a broken dhclient together with the (presumably) hacked up initscripts that call ethtool? -- error compiling committee.c: too many arguments to function