From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] Fix KVM/IA-64 build issue in latest kvm.git.
Date: Tue, 19 Aug 2008 13:41:23 +0300
Message-ID: <48AAA353.3060204@qumranet.com>
References: <42DFA526FC41B1429CE7279EF83C6BDC017F9D9A@pdsmsx415.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm-ia64@vger.kernel.org, kvm@vger.kernel.org
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:13752 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751364AbYHSKlZ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 19 Aug 2008 06:41:25 -0400
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC017F9D9A@pdsmsx415.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Zhang, Xiantao wrote:
> From d53dfacedea40213382694229700d02bfa72d923 Mon Sep 17 00:00:00 2001
> From: Xiantao Zhang <xiantao.zhang@intel.com>
> Date: Tue, 19 Aug 2008 17:33:21 +0800
> Subject: [PATCH] KVM: KVM/IA-64: Fix kvm/ia64's build issue.
>
> Disable irq ack notification for ia64.
> Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
> ---
>  virt/kvm/ioapic.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
> index 515cd7c..992199b 100644
> --- a/virt/kvm/ioapic.c
> +++ b/virt/kvm/ioapic.c
> @@ -39,7 +39,10 @@
>  
>  #include "ioapic.h"
>  #include "lapic.h"
> +
> +#ifdef CONFIG_X86
>  #include "irq.h"
> +#endif
>   

Please keep the include; add an ia64 specific irq.h instead.

>  
>  #if 0
>  #define ioapic_debug(fmt,arg...) printk(KERN_WARNING fmt,##arg)
> @@ -293,7 +296,9 @@ static void __kvm_ioapic_update_eoi(struct
> kvm_ioapic *ioapic, int gsi,
>  
>  	ent = &ioapic->redirtbl[gsi];
>  
> +#ifdef CONFIG_X86
>  	kvm_notify_acked_irq(ioapic->kvm, gsi);
> +#endif
>  
>   

Keep this as well.  You can have a nop-op irq notification API, and 
later merge with x86.  I think you will need irq ack notification if you 
implement device assignment, or for improved timekeeping.


-- 
error compiling committee.c: too many arguments to function