From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] Work around dhclient brokenness Date: Tue, 19 Aug 2008 18:35:08 -0500 Message-ID: <48AB58AC.7050909@us.ibm.com> References: <1218829632-19037-1-git-send-email-aliguori@us.ibm.com> <20080819051355.GA8013@puku.stupidest.org> <20080819051708.GA29881@gondor.apana.org.au> <200808191908.23665.rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Herbert Xu , Chris Wedgwood , Avi Kivity , kvm@vger.kernel.org, Mark McLoughlin To: Rusty Russell Return-path: Received: from e35.co.us.ibm.com ([32.97.110.153]:40086 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752683AbYHSXfv (ORCPT ); Tue, 19 Aug 2008 19:35:51 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e35.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m7JNZo6s007171 for ; Tue, 19 Aug 2008 19:35:51 -0400 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m7JNZoQ9054264 for ; Tue, 19 Aug 2008 17:35:50 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m7JNZn88015581 for ; Tue, 19 Aug 2008 17:35:50 -0600 In-Reply-To: <200808191908.23665.rusty@rustcorp.com.au> Sender: kvm-owner@vger.kernel.org List-ID: Rusty Russell wrote: > On Tuesday 19 August 2008 15:17:08 Herbert Xu wrote: > >> On Mon, Aug 18, 2008 at 10:13:55PM -0700, Chris Wedgwood wrote: >> >>> CSUM2 sounds so ugly though. Features seem to get added and never >>> removed.... how about if this had a documented short lifetime (if it >>> really must go in)? >>> >> All we need is a simple toggle to disable checksum offload. Every >> NIC that offers receive checksum offload allows it to be disabled. >> virtio shouldn't be any different. >> >> Resetting the NIC seems a bit over the top. >> > > Not really. We could extend the protocol, but that's currently how feature > negotiation works: you can't do it while the device is live. That seemed > simplest. I learnt from Xen :) > > (Of course, we don't need to *disable* it, we need to *enable* it). > Checksum offload enabled could be a config flag. Then it could be toggled while the device is live. Of course, you need a feature flag for the config flag. Regards, Anthony Liguori > Cheers, > Rusty. >