Re: [PATCH][RESEND] x86 emulator: Add in/out instructions (opcodes 0xe4-0xe7, 0xec-0xef)

[Avi Kivity <avi@qumranet.com>]

Mohammed Gamal wrote:
> On Wed, Aug 20, 2008 at 11:42 AM, Avi Kivity <avi@qumranet.com> wrote:
>   
>> Mohammed Gamal wrote:
>>     
>>> The patch adds in/out instructions to the x86 emulator.
>>>
>>> The instruction was encountered while running the BIOS while using
>>> the invalid guest state emulation patch.
>>>
>>>       
>> We still don't have a testcase for this.
>>
>>     
> To be clear, do you want an emulator test case (in
> user/test/x86/emulator.c) for every instruction added to the emulator?
>   

Yes.  We've been bitten by rarely-used instructions being broken.

I've now added a simple harness to test these instructions.  It works by 
jumping into big real mode, forcing kvm to emulate (if 
emulate_invalid_guest_state=1) and returning.

Please review it as well as the few fixes I've made in kvm to support 
it.  It's in the 'realmode' branch of both kvm.git and 
kvm-userspace.git.  Once it passes regression testing, I'll merge it 
into master.

-- 
error compiling committee.c: too many arguments to function