From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: qemu: Handle tap fds with IFF_VNET_HDR Date: Wed, 20 Aug 2008 20:27:57 +0300 Message-ID: <48AC541D.2090801@qumranet.com> References: <1218485535-877-1-git-send-email-markmc@redhat.com> <48A1957C.4070007@qumranet.com> <1218638393.29159.38.camel@muff> <48A30ABE.3040903@qumranet.com> <1219251898.5068.33.camel@muff> <1219252197.5068.38.camel@muff> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from il.qumranet.com ([212.179.150.194]:38115 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752579AbYHTR17 (ORCPT ); Wed, 20 Aug 2008 13:27:59 -0400 In-Reply-To: <1219252197.5068.38.camel@muff> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > I would have included that link in the previous mail, but I see another > one of my "patch appended" mails ended up being quoted fully in the > commit message: > > http://git.kernel.org/?p=virt/kvm/kvm-userspace.git;a=commit;h=db424ac3052fe9392e3287b6d8cbfa9e9706cecd > > Other people seem to manage to avoid this, but trying it out myself with > git-am the best I can come up with is to run "git-am -i" and edit the > commit message, which sucks. > > Are others using some other mbox-to-git-commits script, I wonder? > > No -- that was my error; I usually edit the commit messages before committing. In this particular case, there was no need to edit any of the patches (except the updated one), which caused me to miss out. I'll keep a better lookup next time. Oh, and there's some trick with triple-dash. If you do > log message > > --- > > junk > > patch Then git-am will ignore junk and use just the log message. That's how the diffstats escape. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.