From: Anthony Liguori <aliguori@us.ibm.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Avi Kivity <avi@qumranet.com>,
Andrea Arcangeli <andrea@qumranet.com>,
kvm-devel <kvm@vger.kernel.org>
Subject: Re: madvise() not triggering page discard with MMU-notifiers
Date: Wed, 20 Aug 2008 15:38:08 -0500 [thread overview]
Message-ID: <48AC80B0.7090508@us.ibm.com> (raw)
In-Reply-To: <20080820011655.GA11137@dmt.cnet>
Marcelo Tosatti wrote:
> Hi Anthony,
>
> On Mon, Aug 18, 2008 at 05:04:25PM -0500, Anthony Liguori wrote:
>
>> Attached is an updated migration patch. It does not appear, however,
>> that madvise() is triggering discarding of pages even with an
>> MMU-notifier enabled kernel. I take it that this is because we're still
>> holding a reference count to the page when it is in the shadow page
>> table? Any ETA on when this will change?
>>
>
> Shadow references should be dropped via kvm_unmap_rmapp -> rmap_remove.
>
> So the symptom is that RSS for the task does not decrease accordingly to
> the ballooned down size?
>
Correct. I run a workload in the guest to touch all of memory, watch
the RSS size go up to 1G, then balloon down to 512mb. I don't see the
RSS size reduce at all though.
This is not the case when just using QEMU. When I get a chance to
debug, the next step will be to annotate the code to see whether
rmap_remove is actually being invoked on madvise().
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-08-20 20:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 22:04 madvise() not triggering page discard with MMU-notifiers Anthony Liguori
2008-08-20 1:16 ` Marcelo Tosatti
2008-08-20 20:38 ` Anthony Liguori [this message]
2008-08-28 14:23 ` Andrea Arcangeli
2008-08-28 22:55 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AC80B0.7090508@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=andrea@qumranet.com \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox