From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Use .fixup instead of .text.fixup on __kvm_handle_fault_on_reboot Date: Thu, 21 Aug 2008 16:49:50 +0300 Message-ID: <48AD727E.4050704@qumranet.com> References: <20080819230008.GX6342@blackpad> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Chris Wright , kvm@vger.kernel.org To: Eduardo Habkost Return-path: Received: from il.qumranet.com ([212.179.150.194]:41866 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756028AbYHUNtw (ORCPT ); Thu, 21 Aug 2008 09:49:52 -0400 In-Reply-To: <20080819230008.GX6342@blackpad> Sender: kvm-owner@vger.kernel.org List-ID: Eduardo Habkost wrote: > [oops. sent it to the old kvm-devel list. sending to the right list, now] > > vmlinux.lds expects the fixup code to be on a section named .fixup. The > .text.fixup section is not mentioned on vmlinux.lds, and is included on > the resulting vmlinux (just after .text) only because of ld heuristics on > placing orphan sections. > > However, placing .text.fixup outside .text breaks the definition of > _etext, making it exclude the .text.fixup contents. That makes .text.fixup > be ignored by the kernel initialization code that needs to know about > section locations, such as the code setting page protection bits. > > Applied, thanks. -- error compiling committee.c: too many arguments to function