From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH 2/2] KVM: Device assignemnt with VT-d
Date: Fri, 22 Aug 2008 21:18:42 +0300
Message-ID: <48AF0302.8060805@qumranet.com>
References: <1218118487-7657-1-git-send-email-benami@il.ibm.com> <200808211213.49883.amit.shah@qumranet.com> <1219316757.25626.15.camel@cluwyn.haifa.ibm.com> <200808221314.02434.amit.shah@qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Ben-Ami Yassour <benami@il.ibm.com>, kvm@vger.kernel.org,
	Muli Ben-Yehuda <muli@il.ibm.com>, weidong.han@intel.com,
	"Kay, Allen M" <allen.m.kay@intel.com>
To: Amit Shah <amit.shah@qumranet.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:47679 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751094AbYHVSSo (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 22 Aug 2008 14:18:44 -0400
In-Reply-To: <200808221314.02434.amit.shah@qumranet.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Amit Shah wrote:
> diff --git a/include/linux/kvm.h b/include/linux/kvm.h
> index d9ef7d3..2956e35 100644
> --- a/include/linux/kvm.h
> +++ b/include/linux/kvm.h
> @@ -495,4 +495,6 @@ struct kvm_assigned_irq {
>         __u32 flags;
>  };
>
> +#define KVM_DEV_ASSIGN_USE_VTD (1 << 1)
> +
>  #endif
>
>
>   

(1 >> 0)?

This is a userspace inteface, so use a generic name like iommu.  We also
need a KVM_CAP so userspace can check whether an iommu is present or not.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.