From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH 2/2] KVM: Device assignemnt with VT-d
Date: Sat, 23 Aug 2008 12:28:50 +0300
Message-ID: <48AFD852.8040604@qumranet.com>
References: <1218118487-7657-1-git-send-email-benami@il.ibm.com> <200808221314.02434.amit.shah@qumranet.com> <48AF0302.8060805@qumranet.com> <200808231427.42578.amit.shah@qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Ben-Ami Yassour <benami@il.ibm.com>, kvm@vger.kernel.org,
	Muli Ben-Yehuda <muli@il.ibm.com>, weidong.han@intel.com,
	"Kay, Allen M" <allen.m.kay@intel.com>
To: Amit Shah <amit.shah@qumranet.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:18387 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751984AbYHWJ2r (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 23 Aug 2008 05:28:47 -0400
In-Reply-To: <200808231427.42578.amit.shah@qumranet.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Amit Shah wrote:
> * On Friday 22 Aug 2008 23:48:42 Avi Kivity wrote:
>   
>> Amit Shah wrote:
>>     
>>> diff --git a/include/linux/kvm.h b/include/linux/kvm.h
>>> index d9ef7d3..2956e35 100644
>>> --- a/include/linux/kvm.h
>>> +++ b/include/linux/kvm.h
>>> @@ -495,4 +495,6 @@ struct kvm_assigned_irq {
>>>         __u32 flags;
>>>  };
>>>
>>> +#define KVM_DEV_ASSIGN_USE_VTD (1 << 1)
>>> +
>>>  #endif
>>>       
>> (1 >> 0)?
>>     
>
> I kept the 1st field reserved for no particular implementation in mind as of 
> now.
>
>   

Why?

>> This is a userspace inteface, so use a generic name like iommu.  We also
>> need a KVM_CAP so userspace can check whether an iommu is present or not.
>>     
>
> We could have multiple hardware IOMMU implementations, like Intel's VT-d and 
> AMD's IOMMU.
>
>   

Not in userspace.  Userspace sees either iommu or no iommu; it doesn't 
care about the iommu model.

> Also, is KVM_CAP_foo needed for this? This is the only #define that'll be used 
> and we can simply do something like
>
> #ifdef KVM_DEV_ASSIGN_USE_VTD
> flags |= KVM_DEV_ASSIGN_USE_VTD
> #endif
>
> ?
>   

That only detects if the headers have the flag, not if the kernel 
actually supports it (and whether there is an iommu in the host).  We 
need run-time detection.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.