public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] KVM: Qemu: Enable kvm/ia64's network.
@ 2008-08-22  9:36 Zhang, Xiantao
  2008-08-24  9:22 ` Avi Kivity
  0 siblings, 1 reply; 6+ messages in thread
From: Zhang, Xiantao @ 2008-08-22  9:36 UTC (permalink / raw)
  To: kvm-ia64, kvm; +Cc: Avi Kivity

[-- Attachment #1: Type: text/plain, Size: 2149 bytes --]

Hi, Avi
   Please help to apply this patch. It will fix kvm/ia64's networking
issue. 
Thanks
Xiantao
>From fe6e28ce9295acba107438979fe6ead0d24f7e20 Mon Sep 17 00:00:00 2001
From: Xiantao Zhang <xiantao.zhang@intel.com>
Date: Fri, 22 Aug 2008 17:14:15 +0800
Subject: [PATCH] KVM: Qemu: Enable kvm/ia64's network.

kvm/ia64's IRQ may >16, but current Qemu can't support it.
Here we implment a IRQ map function to solve this issue to
enable its networking.

Signed-off-by: Anthony Xu <anthony.xu@intel.com>
Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
---
 qemu/hw/ipf.c |   24 ++++++++++++++++++++++++
 qemu/hw/pci.c |    9 +++++++++
 2 files changed, 33 insertions(+), 0 deletions(-)

diff --git a/qemu/hw/ipf.c b/qemu/hw/ipf.c
index b11e328..ffa7843 100644
--- a/qemu/hw/ipf.c
+++ b/qemu/hw/ipf.c
@@ -672,3 +672,27 @@ QEMUMachine ipf_machine = {
     ipf_init_pci,
     VGA_RAM_SIZE + VGA_RAM_SIZE,
 };
+
+#define IOAPIC_NUM_PINS 48
+
+static int ioapic_irq_count[IOAPIC_NUM_PINS];
+
+int ioapic_map_irq(int devfn, int irq_num)
+{
+    int irq, dev;
+    dev = devfn >> 3;
+    irq = ((((dev << 2) + (dev >> 3) + irq_num) & 31) + 16);
+    return irq;
+}
+
+void ioapic_set_irq(void *opaque, int vector, int level)
+{
+    if( level )
+        ioapic_irq_count[vector] += 1;
+    else
+        ioapic_irq_count[vector] -= 1;
+
+    if (kvm_enabled())
+	if (kvm_set_irq(vector, ioapic_irq_count[vector] == 0))
+	    return;
+}
diff --git a/qemu/hw/pci.c b/qemu/hw/pci.c
index 92683d1..fac58c5 100644
--- a/qemu/hw/pci.c
+++ b/qemu/hw/pci.c
@@ -544,6 +544,15 @@ static void pci_set_irq(void *opaque, int irq_num,
int level)
         return;
 
     pci_dev->irq_state[irq_num] = level;
+#if defined(TARGET_IA64)
+{   int irq;
+    extern int ioapic_map_irq(int devfn, int irq_num);
+    extern void ioapic_set_irq(void *opaque, int vector, int level);
+    
+    irq = ioapic_map_irq(pci_dev->devfn, irq_num);
+    ioapic_set_irq(NULL, irq, level);
+}
+#endif
     for (;;) {
         bus = pci_dev->bus;
         irq_num = bus->map_irq(pci_dev, irq_num);
-- 
1.5.1

[-- Attachment #2: 0001-KVM-Qemu-Enable-kvm-ia64-s-network.patch --]
[-- Type: application/octet-stream, Size: 1972 bytes --]

From fe6e28ce9295acba107438979fe6ead0d24f7e20 Mon Sep 17 00:00:00 2001
From: Xiantao Zhang <xiantao.zhang@intel.com>
Date: Fri, 22 Aug 2008 17:14:15 +0800
Subject: [PATCH] KVM: Qemu: Enable kvm/ia64's network.

kvm/ia64's IRQ may >16, but current Qemu can't support it.
Here we implment a IRQ map function to solve this issue to
enable its networking.

Signed-off-by: Anthony Xu <anthony.xu@intel.com>
Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
---
 qemu/hw/ipf.c |   24 ++++++++++++++++++++++++
 qemu/hw/pci.c |    9 +++++++++
 2 files changed, 33 insertions(+), 0 deletions(-)

diff --git a/qemu/hw/ipf.c b/qemu/hw/ipf.c
index b11e328..ffa7843 100644
--- a/qemu/hw/ipf.c
+++ b/qemu/hw/ipf.c
@@ -672,3 +672,27 @@ QEMUMachine ipf_machine = {
     ipf_init_pci,
     VGA_RAM_SIZE + VGA_RAM_SIZE,
 };
+
+#define IOAPIC_NUM_PINS 48
+
+static int ioapic_irq_count[IOAPIC_NUM_PINS];
+
+int ioapic_map_irq(int devfn, int irq_num)
+{
+    int irq, dev;
+    dev = devfn >> 3;
+    irq = ((((dev << 2) + (dev >> 3) + irq_num) & 31) + 16);
+    return irq;
+}
+
+void ioapic_set_irq(void *opaque, int vector, int level)
+{
+    if( level )
+        ioapic_irq_count[vector] += 1;
+    else
+        ioapic_irq_count[vector] -= 1;
+
+    if (kvm_enabled())
+	if (kvm_set_irq(vector, ioapic_irq_count[vector] == 0))
+	    return;
+}
diff --git a/qemu/hw/pci.c b/qemu/hw/pci.c
index 92683d1..fac58c5 100644
--- a/qemu/hw/pci.c
+++ b/qemu/hw/pci.c
@@ -544,6 +544,15 @@ static void pci_set_irq(void *opaque, int irq_num, int level)
         return;
 
     pci_dev->irq_state[irq_num] = level;
+#if defined(TARGET_IA64)
+{   int irq;
+    extern int ioapic_map_irq(int devfn, int irq_num);
+    extern void ioapic_set_irq(void *opaque, int vector, int level);
+    
+    irq = ioapic_map_irq(pci_dev->devfn, irq_num);
+    ioapic_set_irq(NULL, irq, level);
+}
+#endif
     for (;;) {
         bus = pci_dev->bus;
         irq_num = bus->map_irq(pci_dev, irq_num);
-- 
1.5.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] KVM: Qemu: Enable kvm/ia64's network.
  2008-08-22  9:36 [PATCH] KVM: Qemu: Enable kvm/ia64's network Zhang, Xiantao
@ 2008-08-24  9:22 ` Avi Kivity
  2008-08-24  9:35   ` Zhang, Xiantao
  0 siblings, 1 reply; 6+ messages in thread
From: Avi Kivity @ 2008-08-24  9:22 UTC (permalink / raw)
  To: Zhang, Xiantao; +Cc: kvm-ia64, kvm

Zhang, Xiantao wrote:
> Hi, Avi
>    Please help to apply this patch. It will fix kvm/ia64's networking
> issue. 
> Thanks
> Xiantao
> From fe6e28ce9295acba107438979fe6ead0d24f7e20 Mon Sep 17 00:00:00 2001
> From: Xiantao Zhang <xiantao.zhang@intel.com>
> Date: Fri, 22 Aug 2008 17:14:15 +0800
> Subject: [PATCH] KVM: Qemu: Enable kvm/ia64's network.
>
> kvm/ia64's IRQ may >16, but current Qemu can't support it.
> Here we implment a IRQ map function to solve this issue to
> enable its networking.
>
> Signed-off-by: Anthony Xu <anthony.xu@intel.com>
> Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
> ---
>  qemu/hw/ipf.c |   24 ++++++++++++++++++++++++
>  qemu/hw/pci.c |    9 +++++++++
>  2 files changed, 33 insertions(+), 0 deletions(-)
>
> diff --git a/qemu/hw/ipf.c b/qemu/hw/ipf.c
> index b11e328..ffa7843 100644
> --- a/qemu/hw/ipf.c
> +++ b/qemu/hw/ipf.c
> @@ -672,3 +672,27 @@ QEMUMachine ipf_machine = {
>      ipf_init_pci,
>      VGA_RAM_SIZE + VGA_RAM_SIZE,
>  };
> +
> +#define IOAPIC_NUM_PINS 48
> +
> +static int ioapic_irq_count[IOAPIC_NUM_PINS];
> +
> +int ioapic_map_irq(int devfn, int irq_num)
> +{
> +    int irq, dev;
> +    dev = devfn >> 3;
> +    irq = ((((dev << 2) + (dev >> 3) + irq_num) & 31) + 16);
> +    return irq;
> +}
> +
> +void ioapic_set_irq(void *opaque, int vector, int level)
> +{
> +    if( level )
>   

if (level)

> +        ioapic_irq_count[vector] += 1;
> +    else
> +        ioapic_irq_count[vector] -= 1;
> +
> +    if (kvm_enabled())
> +	if (kvm_set_irq(vector, ioapic_irq_count[vector] == 0))
> +	    return;
> +}
>   

Please move this to pci.c.  This can be made to work for x86 too.

> diff --git a/qemu/hw/pci.c b/qemu/hw/pci.c
> index 92683d1..fac58c5 100644
> --- a/qemu/hw/pci.c
> +++ b/qemu/hw/pci.c
> @@ -544,6 +544,15 @@ static void pci_set_irq(void *opaque, int irq_num,
> int level)
>          return;
>  
>      pci_dev->irq_state[irq_num] = level;
> +#if defined(TARGET_IA64)
> +{   int irq;
> +    extern int ioapic_map_irq(int devfn, int irq_num);
> +    extern void ioapic_set_irq(void *opaque, int vector, int level);
>   

Use headers instead (or move the functions here).

> +    
> +    irq = ioapic_map_irq(pci_dev->devfn, irq_num);
> +    ioapic_set_irq(NULL, irq, level);
> +}
>   


> +#endif
>      for (;;) {
>          bus = pci_dev->bus;
>          irq_num = bus->map_irq(pci_dev, irq_num);
>   


-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] KVM: Qemu: Enable kvm/ia64's network.
  2008-08-24  9:22 ` Avi Kivity
@ 2008-08-24  9:35   ` Zhang, Xiantao
  2008-08-24  9:50     ` Avi Kivity
  0 siblings, 1 reply; 6+ messages in thread
From: Zhang, Xiantao @ 2008-08-24  9:35 UTC (permalink / raw)
  To: Avi Kivity; +Cc: kvm-ia64, kvm

Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> Hi, Avi
>>    Please help to apply this patch. It will fix kvm/ia64's
>> networking issue. Thanks
>> Xiantao
>> From fe6e28ce9295acba107438979fe6ead0d24f7e20 Mon Sep 17 00:00:00
>> 2001 From: Xiantao Zhang <xiantao.zhang@intel.com>
>> Date: Fri, 22 Aug 2008 17:14:15 +0800
>> Subject: [PATCH] KVM: Qemu: Enable kvm/ia64's network.
>> 
>> kvm/ia64's IRQ may >16, but current Qemu can't support it.
>> Here we implment a IRQ map function to solve this issue to
>> enable its networking.
>> 
>> Signed-off-by: Anthony Xu <anthony.xu@intel.com>
>> Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com> ---
>>  qemu/hw/ipf.c |   24 ++++++++++++++++++++++++
>>  qemu/hw/pci.c |    9 +++++++++
>>  2 files changed, 33 insertions(+), 0 deletions(-)
>> 
>> diff --git a/qemu/hw/ipf.c b/qemu/hw/ipf.c
>> index b11e328..ffa7843 100644
>> --- a/qemu/hw/ipf.c
>> +++ b/qemu/hw/ipf.c
>> @@ -672,3 +672,27 @@ QEMUMachine ipf_machine = {
>>      ipf_init_pci,
>>      VGA_RAM_SIZE + VGA_RAM_SIZE,
>>  };
>> +
>> +#define IOAPIC_NUM_PINS 48
>> +
>> +static int ioapic_irq_count[IOAPIC_NUM_PINS];
>> +
>> +int ioapic_map_irq(int devfn, int irq_num)
>> +{
>> +    int irq, dev;
>> +    dev = devfn >> 3;
>> +    irq = ((((dev << 2) + (dev >> 3) + irq_num) & 31) + 16); +   
>> return irq; +}
>> +
>> +void ioapic_set_irq(void *opaque, int vector, int level) +{
>> +    if( level )
>> 
> 
> if (level)
> 
>> +        ioapic_irq_count[vector] += 1;
>> +    else
>> +        ioapic_irq_count[vector] -= 1;
>> +
>> +    if (kvm_enabled())
>> +	if (kvm_set_irq(vector, ioapic_irq_count[vector] == 0)) +

>> return; +}
>> 
> 
> Please move this to pci.c.  This can be made to work for x86 too.

So, we should change X86 bios's dsdt also ? 
Thanks
Xiantao

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] KVM: Qemu: Enable kvm/ia64's network.
  2008-08-24  9:35   ` Zhang, Xiantao
@ 2008-08-24  9:50     ` Avi Kivity
  2008-08-25  1:53       ` Zhang, Xiantao
  0 siblings, 1 reply; 6+ messages in thread
From: Avi Kivity @ 2008-08-24  9:50 UTC (permalink / raw)
  To: Zhang, Xiantao; +Cc: kvm-ia64, kvm

Zhang, Xiantao wrote:
>>
>> Please move this to pci.c.  This can be made to work for x86 too.
>>     
>
> So, we should change X86 bios's dsdt also ? 
>   

If you like.  But I would also accept a patch that makes it conditional 
on ia64.

-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] KVM: Qemu: Enable kvm/ia64's network.
  2008-08-24  9:50     ` Avi Kivity
@ 2008-08-25  1:53       ` Zhang, Xiantao
  2008-08-25 11:35         ` Avi Kivity
  0 siblings, 1 reply; 6+ messages in thread
From: Zhang, Xiantao @ 2008-08-25  1:53 UTC (permalink / raw)
  To: Avi Kivity; +Cc: kvm-ia64, kvm

[-- Attachment #1: Type: text/plain, Size: 3128 bytes --]

 Hi, Avi 
     Since x86 and IA-64's ioapic don't have same number of PINs. They
have to use different map functions.  Besides,  we also need to modify
x86's dsdt to meet the map,  so in this patch, I just changed it for
ia64 side, and didn't touch x86.  Maybe x86 needs another patch. Please
help to apply. 
Thanks
Xiantao

>From d2bc9284cb659d120beb7dd224567f7a859d80ce Mon Sep 17 00:00:00 2001
From: Xiantao Zhang <xiantao.zhang@intel.com>
Date: Mon, 25 Aug 2008 09:28:29 +0800
Subject: [PATCH] KVM: Qemu: Enable kvm/ia64's network.

kvm/ia64's IRQ may >16, but current Qemu can't support it.
Here we implment a IRQ map function to solve this issue to
enable its networking.

Signed-off-by: Anthony Xu <anthony.xu@intel.com>
Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
---
 qemu/hw/ipf.c |   29 +++++++++++++++++++++++++++++
 qemu/hw/pci.c |    5 +++++
 2 files changed, 34 insertions(+), 0 deletions(-)

diff --git a/qemu/hw/ipf.c b/qemu/hw/ipf.c
index b11e328..134076a 100644
--- a/qemu/hw/ipf.c
+++ b/qemu/hw/ipf.c
@@ -672,3 +672,32 @@ QEMUMachine ipf_machine = {
     ipf_init_pci,
     VGA_RAM_SIZE + VGA_RAM_SIZE,
 };
+
+#define IOAPIC_NUM_PINS 48
+
+static int ioapic_irq_count[IOAPIC_NUM_PINS];
+
+static int ioapic_map_irq(int devfn, int irq_num)
+{
+    int irq, dev;
+    dev = devfn >> 3;
+    irq = ((((dev << 2) + (dev >> 3) + irq_num) & 31) + 16);
+    return irq;
+}
+
+void ioapic_set_irq(void *opaque, int irq_num, int level)
+{
+    int vector;
+
+    PCIDevice *pci_dev = (PCIDevice *)opaque;
+    vector = ioapic_map_irq(pci_dev->devfn, irq_num);
+
+    if (level)
+        ioapic_irq_count[vector] += 1;
+    else
+        ioapic_irq_count[vector] -= 1;
+
+    if (kvm_enabled())
+	if (kvm_set_irq(vector, ioapic_irq_count[vector] == 0))
+	    return;
+}
diff --git a/qemu/hw/pci.c b/qemu/hw/pci.c
index 92683d1..07d37a8 100644
--- a/qemu/hw/pci.c
+++ b/qemu/hw/pci.c
@@ -544,6 +544,11 @@ static void pci_set_irq(void *opaque, int irq_num,
int level)
         return;
 
     pci_dev->irq_state[irq_num] = level;
+
+#if defined(TARGET_IA64)
+    ioapic_set_irq(pci_dev, irq_num, level);
+#endif
+
     for (;;) {
         bus = pci_dev->bus;
         irq_num = bus->map_irq(pci_dev, irq_num);
-- 
1.5.1



-----Original Message-----
From: kvm-owner@vger.kernel.org [mailto:kvm-owner@vger.kernel.org] On
Behalf Of Avi Kivity
Sent: Sunday, August 24, 2008 5:51 PM
To: Zhang, Xiantao
Cc: kvm-ia64@vger.kernel.org; kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Qemu: Enable kvm/ia64's network.

Zhang, Xiantao wrote:
>>
>> Please move this to pci.c.  This can be made to work for x86 too.
>>     
>
> So, we should change X86 bios's dsdt also ? 
>   

If you like.  But I would also accept a patch that makes it conditional 
on ia64.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: 0001-KVM-Qemu-Enable-kvm-ia64-s-network.patch --]
[-- Type: application/octet-stream, Size: 1913 bytes --]

From d2bc9284cb659d120beb7dd224567f7a859d80ce Mon Sep 17 00:00:00 2001
From: Xiantao Zhang <xiantao.zhang@intel.com>
Date: Mon, 25 Aug 2008 09:28:29 +0800
Subject: [PATCH] KVM: Qemu: Enable kvm/ia64's network.

kvm/ia64's IRQ may >16, but current Qemu can't support it.
Here we implment a IRQ map function to solve this issue to
enable its networking.

Signed-off-by: Anthony Xu <anthony.xu@intel.com>
Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
---
 qemu/hw/ipf.c |   29 +++++++++++++++++++++++++++++
 qemu/hw/pci.c |    5 +++++
 2 files changed, 34 insertions(+), 0 deletions(-)

diff --git a/qemu/hw/ipf.c b/qemu/hw/ipf.c
index b11e328..134076a 100644
--- a/qemu/hw/ipf.c
+++ b/qemu/hw/ipf.c
@@ -672,3 +672,32 @@ QEMUMachine ipf_machine = {
     ipf_init_pci,
     VGA_RAM_SIZE + VGA_RAM_SIZE,
 };
+
+#define IOAPIC_NUM_PINS 48
+
+static int ioapic_irq_count[IOAPIC_NUM_PINS];
+
+static int ioapic_map_irq(int devfn, int irq_num)
+{
+    int irq, dev;
+    dev = devfn >> 3;
+    irq = ((((dev << 2) + (dev >> 3) + irq_num) & 31) + 16);
+    return irq;
+}
+
+void ioapic_set_irq(void *opaque, int irq_num, int level)
+{
+    int vector;
+
+    PCIDevice *pci_dev = (PCIDevice *)opaque;
+    vector = ioapic_map_irq(pci_dev->devfn, irq_num);
+
+    if (level)
+        ioapic_irq_count[vector] += 1;
+    else
+        ioapic_irq_count[vector] -= 1;
+
+    if (kvm_enabled())
+	if (kvm_set_irq(vector, ioapic_irq_count[vector] == 0))
+	    return;
+}
diff --git a/qemu/hw/pci.c b/qemu/hw/pci.c
index 92683d1..07d37a8 100644
--- a/qemu/hw/pci.c
+++ b/qemu/hw/pci.c
@@ -544,6 +544,11 @@ static void pci_set_irq(void *opaque, int irq_num, int level)
         return;
 
     pci_dev->irq_state[irq_num] = level;
+
+#if defined(TARGET_IA64)
+    ioapic_set_irq(pci_dev, irq_num, level);
+#endif
+
     for (;;) {
         bus = pci_dev->bus;
         irq_num = bus->map_irq(pci_dev, irq_num);
-- 
1.5.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] KVM: Qemu: Enable kvm/ia64's network.
  2008-08-25  1:53       ` Zhang, Xiantao
@ 2008-08-25 11:35         ` Avi Kivity
  0 siblings, 0 replies; 6+ messages in thread
From: Avi Kivity @ 2008-08-25 11:35 UTC (permalink / raw)
  To: Zhang, Xiantao; +Cc: kvm-ia64, kvm

Zhang, Xiantao wrote:
>  Hi, Avi 
>      Since x86 and IA-64's ioapic don't have same number of PINs. They
> have to use different map functions.  Besides,  we also need to modify
> x86's dsdt to meet the map,  so in this patch, I just changed it for
> ia64 side, and didn't touch x86.  Maybe x86 needs another patch. Please
> help to apply. 
> Thanks
> Xiantao
>
> From d2bc9284cb659d120beb7dd224567f7a859d80ce Mon Sep 17 00:00:00 2001
> From: Xiantao Zhang <xiantao.zhang@intel.com>
> Date: Mon, 25 Aug 2008 09:28:29 +0800
> Subject: [PATCH] KVM: Qemu: Enable kvm/ia64's network.
>
> kvm/ia64's IRQ may >16, but current Qemu can't support it.
> Here we implment a IRQ map function to solve this issue to
> enable its networking.
>
> diff --git a/qemu/hw/ipf.c b/qemu/hw/ipf.c
> index b11e328..134076a 100644
> --- a/qemu/hw/ipf.c
> +++ b/qemu/hw/ipf.c
> @@ -672,3 +672,32 @@ QEMUMachine ipf_machine = {
>      ipf_init_pci,
>      VGA_RAM_SIZE + VGA_RAM_SIZE,
>  };
> +
> +#define IOAPIC_NUM_PINS 48
> +
> +static int ioapic_irq_count[IOAPIC_NUM_PINS];
> +
> +static int ioapic_map_irq(int devfn, int irq_num)
> +{
> +    int irq, dev;
> +    dev = devfn >> 3;
> +    irq = ((((dev << 2) + (dev >> 3) + irq_num) & 31) + 16);
> +    return irq;
> +}
> +
> +void ioapic_set_irq(void *opaque, int irq_num, int level)
> +{
> +    int vector;
> +
> +    PCIDevice *pci_dev = (PCIDevice *)opaque;
> +    vector = ioapic_map_irq(pci_dev->devfn, irq_num);
> +
> +    if (level)
> +        ioapic_irq_count[vector] += 1;
> +    else
> +        ioapic_irq_count[vector] -= 1;
> +
> +    if (kvm_enabled())
> +	if (kvm_set_irq(vector, ioapic_irq_count[vector] == 0))
> +	    return;
> +}
>   

I could move this myself to pci.c, but then I might break it since I 
still don't have an ia64 host.  It's therefore best to put this in pci.c.

The formula can be made generic by replacing '& 31' by '% 
(IOAPIC_NUM_PINS - 16)', and having defining IOAPIC_NUM_PINS according 
to architecture.

> index 92683d1..07d37a8 100644
> --- a/qemu/hw/pci.c
> +++ b/qemu/hw/pci.c
> @@ -544,6 +544,11 @@ static void pci_set_irq(void *opaque, int irq_num,
> int level)
>          return;
>  
>      pci_dev->irq_state[irq_num] = level;
> +
> +#if defined(TARGET_IA64)
> +    ioapic_set_irq(pci_dev, irq_num, level);
> +#endif
> +
>      for (;;) {
>          bus = pci_dev->bus;
>          irq_num = bus->map_irq(pci_dev, irq_num);
>   

This generates a compile warning now.

Please move it to pci.c.  You only need to make sure it works on ia64; I 
will take care of x86.

-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2008-08-25 11:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-22  9:36 [PATCH] KVM: Qemu: Enable kvm/ia64's network Zhang, Xiantao
2008-08-24  9:22 ` Avi Kivity
2008-08-24  9:35   ` Zhang, Xiantao
2008-08-24  9:50     ` Avi Kivity
2008-08-25  1:53       ` Zhang, Xiantao
2008-08-25 11:35         ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox