From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loaded on Intel hosts Date: Mon, 25 Aug 2008 13:03:19 +0300 Message-ID: <48B28367.2040500@qumranet.com> References: <1219655506-27418-1-git-send-email-avi@qumranet.com> <20080825091508.GC9114@elte.hu> <48B27AFE.3080704@qumranet.com> <20080825093020.GA5617@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Eric W. Biederman" , linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Ingo Molnar Return-path: Received: from il.qumranet.com ([212.179.150.194]:18763 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753509AbYHYKDV (ORCPT ); Mon, 25 Aug 2008 06:03:21 -0400 In-Reply-To: <20080825093020.GA5617@elte.hu> Sender: kvm-owner@vger.kernel.org List-ID: Ingo Molnar wrote: >> I'm a little worried about making emergency restart more complex. >> >> Another thing that worries me is that emergency_restart() doesn't >> reset the box -- it sends INIT. We could do better by using the ACPI >> FADT reset register (hopefully that's connected to RESET). >> > > reboot was always a bit fragile - i think we should only do that if we > find a box where the FADT reset works better than the first-wave > approaches we try. > > It worked on my host. Since it will fall back to keyboard reset and triple fault, it seems fairly safe. >> Which seems to be what we want? Maybe we should just try acpi_reboot() >> before the other stuff. >> > > perhaps in a separate commit, for v2.6.28 at the earliest. > I'll send a patch. I don't think my earlier patch is worthwhile as all machines with VT are acpi capable. -- error compiling committee.c: too many arguments to function