Re: [PATCH]KVM: kvm/ia64: select ANON_INODES PREEMPT_NOTIFIERS, once

Avi Kivity
2008-08-25T09:03:03Z

Zhang, Xiantao wrote:
> From 2c14c54eed790553fddbcb3970f0967a4aa79dca Mon Sep 17 00:00:00 2001
> From: Xiantao Zhang <xiantao.zhang@intel.com>
> Date: Sat, 23 Aug 2008 10:21:06 +0800
> Subject: [PATCH] KVM: kvm/ia64: select ANON_INODES PREEMPT_NOTIFIERS,
> once
> virtualization configured.
>
> Once virtulization configured, make PREEMPT_NOTIFIERS, ANON_INODES
> selected by default.
>

What is the motivation for this? Don't things work as is?

> Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
> ---
> arch/ia64/kvm/Kconfig | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/ia64/kvm/Kconfig b/arch/ia64/kvm/Kconfig
> index 7914e48..07f6b69 100644
> --- a/arch/ia64/kvm/Kconfig
> +++ b/arch/ia64/kvm/Kconfig
> @@ -7,6 +7,8 @@ config HAVE_KVM
> menuconfig VIRTUALIZATION
> bool "Virtualization"
> depends on HAVE_KVM || IA64
> + select PREEMPT_NOTIFIERS
> + select ANON_INODES
> default y
>

Suppose VIRTUALIZATION is selected but KVM is not. Why select
ANON_INODES and PREEMPT_NOTIFIERS?

> ---help---
> Say Y here to get to see options for using your Linux host to
> run other
> @@ -20,8 +22,6 @@ if VIRTUALIZATION
> config KVM
> tristate "Kernel-based Virtual Machine (KVM) support"
> depends on HAVE_KVM && EXPERIMENTAL
> - select PREEMPT_NOTIFIERS
> - select ANON_INODES
> ---help---
> Support hosting fully virtualized guest machines using
> hardware
> virtualization extensions. You will need a fairly recent
>

--
error compiling committee.c: too many arguments to function