Re: [PATCH]KVM: kvm/ia64: select ANON_INODES PREEMPT_NOTIFIERS, once

Avi Kivity
2008-08-25T10:15:11Z

Zhang, Xiantao wrote:
> Avi Kivity wrote:
>
>> Zhang, Xiantao wrote:
>>
>>> From 2c14c54eed790553fddbcb3970f0967a4aa79dca Mon Sep 17 00:00:00
>>> 2001 From: Xiantao Zhang <xiantao.zhang@intel.com>
>>> Date: Sat, 23 Aug 2008 10:21:06 +0800
>>> Subject: [PATCH] KVM: kvm/ia64: select ANON_INODES
>>> PREEMPT_NOTIFIERS, once virtualization configured.
>>>
>>> Once virtulization configured, make PREEMPT_NOTIFIERS, ANON_INODES
>>> selected by default.
>>>
>>>
>> What is the motivation for this? Don't things work as is
>>
>
> You know, kvm depends on these two configrations. If user doesn't
> configure KVM when building host kernel, then PREEMPT_NOTIFIERS and
> ANON_INODES shouldn't be selected . In this case, once user wants to
> exercise KVM later, he has to replace the host kernel again. To some
> high-end servers, it maybe infeasible to replace kernel and get a
> restart. So I want to get them selected once users doesn't disable
> virtulization explictly.

But it also means the user will have these features enabled needlessly.
Right now when KVM is the only option under the virtualization menu,
this may be okay, but if other features are added, this is not acceptable.

Really, if users want KVM, they should enable it in their kernel
configuration.

--
error compiling committee.c: too many arguments to function