From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] x86: default to reboot via ACPI Date: Tue, 26 Aug 2008 15:14:33 +0300 Message-ID: <48B3F3A9.8030709@qumranet.com> References: <1219659087-17536-1-git-send-email-avi@qumranet.com> <20080826095032.GA309@elf.ucw.cz> <48B3D579.40502@qumranet.com> <20080826113317.520cbab1@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Pavel Machek , Ingo Molnar , "Eric W. Biederman" , linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Alan Cox Return-path: Received: from il.qumranet.com ([212.179.150.194]:48363 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753808AbYHZMOe (ORCPT ); Tue, 26 Aug 2008 08:14:34 -0400 In-Reply-To: <20080826113317.520cbab1@lxorguk.ukuu.org.uk> Sender: kvm-owner@vger.kernel.org List-ID: Alan Cox wrote: >> It seems excessive. Most machines will hardly run without acpi. >> > > *Recent* machines. > Most machines are recent machines. If a machine doesn't have acpi, this change is safe. If a machine has acpi, but doesn't have the reset register set in the FADT, this change is safe. If a machine has acpi, and the reset register is set incorrectly, this change is safe. If a machine has acpi, and the reset register is wired to the launch controller, then perhaps this change is unsafe. Don't issue sysrq-b on such machines. -- error compiling committee.c: too many arguments to function