From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] KVM: Device Assignment with VT-d Date: Tue, 26 Aug 2008 17:41:02 +0300 Message-ID: <48B415FE.4030006@qumranet.com> References: <1219740935-19701-1-git-send-email-amit.shah@qumranet.com> <1219740935-19701-3-git-send-email-amit.shah@qumranet.com> <42DFA526FC41B1429CE7279EF83C6BDC0188EA6D@pdsmsx415.ccr.corp.intel.com> <200808261605.42646.amit.shah@qumranet.com> <42DFA526FC41B1429CE7279EF83C6BDC0188EA70@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Amit Shah , kvm@vger.kernel.org, muli@il.ibm.com, anthony@codemonkey.ws, jbarnes@virtuousgeek.org, "Woodhouse, David" , "Gross, Mark" , benami@il.ibm.com, "Han, Weidong" , "Kay, Allen M" To: "Zhang, Xiantao" Return-path: Received: from il.qumranet.com ([212.179.150.194]:35714 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754219AbYHZOlE (ORCPT ); Tue, 26 Aug 2008 10:41:04 -0400 In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC0188EA70@pdsmsx415.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Zhang, Xiantao wrote: > Amit Shah wrote: > >> * On Tuesday 26 Aug 2008 15:58:42 Zhang, Xiantao wrote: >> >>> Maybe vtd.c should be put @ virt/kvm so that ia64 can share it to >>> avoid future code move. >>> >> As of now, device assignment resides inside the x86 directory and is >> only tested in x86 environment. Once we support ia64, we'll have a >> lot of files moving anyway. >> > > Just a suggestion. Even if put it @ virt/kvm, we still can make it only > I'm fine with keeping it in x86 and moving it later, since the code is late already. However if someone is willing to do the work to move it to virt/kvm/, I'm happy with that as well. -- error compiling committee.c: too many arguments to function