From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: SVM: fix random segfaults with NPT enabled Date: Thu, 28 Aug 2008 18:47:30 +0300 Message-ID: <48B6C892.6030304@qumranet.com> References: <48B55C56.2060503@qumranet.com> <20080827135731.GC26059@amd.com> <48B57126.7000603@qumranet.com> <20080827153550.GB3801@8bytes.org> <48B577C3.3050302@qumranet.com> <20080827162715.GA28498@amd.com> <48B58599.1040509@qumranet.com> <48B587EC.7020606@qumranet.com> <20080828145838.GA4971@amd.com> <48B6C12D.1020501@qumranet.com> <20080828151951.GA4895@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Joerg Rodel , kvm@vger.kernel.org, stable@kernel.org, Alexander Graf To: Joerg Roedel Return-path: Received: from il.qumranet.com ([212.179.150.194]:44416 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752754AbYH1Prd (ORCPT ); Thu, 28 Aug 2008 11:47:33 -0400 In-Reply-To: <20080828151951.GA4895@8bytes.org> Sender: kvm-owner@vger.kernel.org List-ID: Joerg Roedel wrote: > Ok, cool. But the bug happens only rarely so I think there is some > probability that this is the missing tlb flush, I think. But lets see. > It reproduces rapidly for me, and it did after adding the missing flush to kvm_mmu_zap_page(). -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.