From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH][RESEND] kvm: testsuite: Consolidate mov r, imm testing
 in	one function
Date: Thu, 28 Aug 2008 19:05:07 +0300
Message-ID: <48B6CCB3.5070900@qumranet.com>
References: <20080827145736.GA7140@mohd-laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, riel@surriel.com
To: Mohammed Gamal <m.gamal005@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:45607 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754922AbYH1QFJ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 28 Aug 2008 12:05:09 -0400
In-Reply-To: <20080827145736.GA7140@mohd-laptop>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Mohammed Gamal wrote:
> Consolidate mov r, imm testing in one function
>
>   

Doesn't apply, likely due to coding style fixes I made to the previous
patch.

> -	if(!regs_equal(&inregs, &outregs, R_AX) || outregs.eax != 1234567890)
> +	if(!regs_equal(inregs, outregs, R_AX) || outregs->eax != 1234567890)
>   

"if _nospace_ (" hurts my eyes.  I find it really confusing.  Please
avoid it.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.