From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 3/3] Add virtio balloon driver (v2) Date: Thu, 28 Aug 2008 17:56:28 -0500 Message-ID: <48B72D1C.9070402@us.ibm.com> References: <1219964075-9888-1-git-send-email-aliguori@us.ibm.com> <1219964075-9888-3-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Avi Kivity To: kvm@vger.kernel.org Return-path: Received: from e33.co.us.ibm.com ([32.97.110.151]:50356 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbYH1W5Q (ORCPT ); Thu, 28 Aug 2008 18:57:16 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e33.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m7SMvGdB025807 for ; Thu, 28 Aug 2008 18:57:16 -0400 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m7SMvFuM213226 for ; Thu, 28 Aug 2008 16:57:15 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m7SMvFee019164 for ; Thu, 28 Aug 2008 16:57:15 -0600 In-Reply-To: <1219964075-9888-3-git-send-email-aliguori@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > This patch adds the virtio balloon driver. It doesn't actually reduce the RSS > size when using KVM (although it does when using -no-kvm). This is because > even with MMU notifiers, we're holding a reference to each page in the shadow > page table. Once we switch to not taking a reference for pages in the shadow > page table, the balloon driver should work as expected. > Too late in the day for me. This comment is totally bogus. Avi: can you just ignore everything but the first sentence? :-) Regards, Anthony Liguori