From: Avi Kivity <avi@qumranet.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 3/3] Add virtio balloon driver (v2)
Date: Fri, 29 Aug 2008 14:21:20 +0300 [thread overview]
Message-ID: <48B7DBB0.605@qumranet.com> (raw)
In-Reply-To: <48B72D1C.9070402@us.ibm.com>
Anthony Liguori wrote:
> Anthony Liguori wrote:
>> This patch adds the virtio balloon driver. It doesn't actually
>> reduce the RSS
>> size when using KVM (although it does when using -no-kvm). This is
>> because
>> even with MMU notifiers, we're holding a reference to each page in
>> the shadow
>> page table. Once we switch to not taking a reference for pages in
>> the shadow
>> page table, the balloon driver should work as expected.
>>
>
> Too late in the day for me. This comment is totally bogus. Avi: can
> you just ignore everything but the first sentence? :-)
>
Actually, the last word in the first sentence is incorrect as well.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-08-29 11:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 22:54 [PATCH 1/3] Extend virtio config routines to support ballooning Anthony Liguori
2008-08-28 22:54 ` [PATCH 2/3] add ballooning infrastructure to QEMU Anthony Liguori
2008-08-28 22:54 ` [PATCH 3/3] Add virtio balloon driver (v2) Anthony Liguori
2008-08-28 22:56 ` Anthony Liguori
2008-08-29 11:21 ` Avi Kivity [this message]
2008-08-29 11:31 ` [PATCH 1/3] Extend virtio config routines to support ballooning Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B7DBB0.605@qumranet.com \
--to=avi@qumranet.com \
--cc=aliguori@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox