From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/3] Add virtio balloon driver (v2) Date: Fri, 29 Aug 2008 14:21:20 +0300 Message-ID: <48B7DBB0.605@qumranet.com> References: <1219964075-9888-1-git-send-email-aliguori@us.ibm.com> <1219964075-9888-3-git-send-email-aliguori@us.ibm.com> <48B72D1C.9070402@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti To: Anthony Liguori Return-path: Received: from il.qumranet.com ([212.179.150.194]:43323 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753208AbYH2LVR (ORCPT ); Fri, 29 Aug 2008 07:21:17 -0400 In-Reply-To: <48B72D1C.9070402@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > Anthony Liguori wrote: >> This patch adds the virtio balloon driver. It doesn't actually >> reduce the RSS >> size when using KVM (although it does when using -no-kvm). This is >> because >> even with MMU notifiers, we're holding a reference to each page in >> the shadow >> page table. Once we switch to not taking a reference for pages in >> the shadow >> page table, the balloon driver should work as expected. >> > > Too late in the day for me. This comment is totally bogus. Avi: can > you just ignore everything but the first sentence? :-) > Actually, the last word in the first sentence is incorrect as well. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.