From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: MMU: Add shadow_accessed_shift Date: Sun, 31 Aug 2008 18:13:54 +0300 Message-ID: <48BAB532.2010701@qumranet.com> References: <1220113098-25053-1-git-send-email-sheng.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Sheng Yang To: yasker@gmail.com Return-path: Received: from il.qumranet.com ([212.179.150.194]:36466 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbYHaPN4 (ORCPT ); Sun, 31 Aug 2008 11:13:56 -0400 In-Reply-To: <1220113098-25053-1-git-send-email-sheng.yang@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: yasker@gmail.com wrote: > From: Sheng Yang > > We use a "fake" A/D bit for EPT, to keep epte behaviour consistent with shadow > spte. But it's not that good for MMU notifier. Now we can only expect return > young=0 for clean_flush_young() in most condition. > > Perhaps we are better off setting shadow_accessed_mask to 0 for ept, and adding a test for clear_flush_young()? This is the only place that needs adjusting as far as I can tell. I don't see what having a fake accessed bit buys us, and I'd like the patch to be as small as possible, since it needs to go into 2.6.26-stable and 2.6.27-rc. -- error compiling committee.c: too many arguments to function