From: Avi Kivity <avi@qumranet.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: kvm-ia64@vger.kernel.org,
"kvm-devel@lists.sourceforge.net" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: Qemu: Set default pm_io_base to 0x1f40.
Date: Sun, 31 Aug 2008 18:14:21 +0300 [thread overview]
Message-ID: <48BAB54D.40405@qumranet.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC018D3B36@pdsmsx415.ccr.corp.intel.com>
Zhang, Xiantao wrote:
> From 6039f279745733c52b291ec45c69eca028567c62 Mon Sep 17 00:00:00 2001
> From: Xiantao Zhang <xiantao.zhang@intel.com>
> Date: Sun, 31 Aug 2008 14:27:23 +0800
> Subject: [PATCH] KVM: Qemu: Set default pm_io_base to 0x1f40.
>
> The firmware of kvm/ia64 use 0x1f40 as default pm_io_base,
> and doesn't have re-configure mechanism, so use 0x1f40 as default value
> to
> support kvm/ia64's power management.
> Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
> ---
> qemu/hw/acpi.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/qemu/hw/acpi.c b/qemu/hw/acpi.c
> index 74535bc..4fc1d3f 100644
> --- a/qemu/hw/acpi.c
> +++ b/qemu/hw/acpi.c
> @@ -498,7 +498,9 @@ i2c_bus *piix4_pm_init(PCIBus *bus, int devfn,
> uint32_t smb_io_base,
> pci_conf[0x0e] = 0x00; // header_type
> pci_conf[0x3d] = 0x01; // interrupt pin 1
>
> - pci_conf[0x40] = 0x01; /* PM io base read only bit */
> + pci_conf[0x40] = 0x41; /* PM io base read only bit */
> + pci_conf[0x41] = 0x1f;
> + pm_write_config(s, 0x80, 0x01, 1); /*Set default pm_io_base
> 0x1f40*/
>
Please limit this to ia64; no need to change x86 behaviour.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-08-31 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-31 8:02 [PATCH] KVM: Qemu: Set default pm_io_base to 0x1f40 Zhang, Xiantao
2008-08-31 15:14 ` Avi Kivity [this message]
2008-08-31 15:23 ` Zhang, Xiantao
2008-08-31 15:45 ` Avi Kivity
2008-09-01 2:06 ` Zhang, Xiantao
2008-09-01 9:32 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BAB54D.40405@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox