From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] kvm: testsuite: Save eflags in exec_in_big_real_mode()
Date: Mon, 01 Sep 2008 12:56:23 +0300
Message-ID: <48BBBC47.1030707@qumranet.com>
References: <20080901014600.GA8107@mohd-laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, riel@surriel.com
To: Mohammed Gamal <m.gamal005@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:14539 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751055AbYIAJ4Z (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 1 Sep 2008 05:56:25 -0400
In-Reply-To: <20080901014600.GA8107@mohd-laptop>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Mohammed Gamal wrote:
> Save eflags in exec_in_big_real_mode(). This is needed to test instructions that
> modify the eflags register.
>
>   

Applied, thanks.

> @@ -82,6 +82,10 @@ static void exec_in_big_real_mode(const struct regs *inregs,
>  		"test_insn: . = . + 16\n\t"
>  		"test_insn_end: \n\t"
>  
> +		/* Save EFLAGS in outregs*/
> +		"pushfl \n\t"
> +		"popl %[save]+36 \n\t"
> +
>  		"xchg %%eax, %[save]+0 \n\t"
>  		"xchg %%ebx, %[save]+4 \n\t"
>  		"xchg %%ecx, %[save]+8 \n\t"
>   

I moved this after the register restoration, since the test may modify %sp.

-- 
error compiling committee.c: too many arguments to function