[PATCH] x86 emulator: Add std and cld instructions (opcodes 0xfc-0xfd)

[PATCH] x86 emulator: Add std and cld instructions (opcodes 0xfc-0xfd)

[Mohammed Gamal]

This adds the std and cld instructions to the emulator.

Encountered while running the BIOS with the invalid guest
state emulation patch.

Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
---
 arch/x86/kvm/x86_emulate.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index d5da7f1..005f1db 100644
--- a/arch/x86/kvm/x86_emulate.c
+++ b/arch/x86/kvm/x86_emulate.c
@@ -180,7 +180,7 @@ static u16 opcode_table[256] = {
 	ImplicitOps, ImplicitOps, Group | Group3_Byte, Group | Group3,
 	/* 0xF8 - 0xFF */
 	ImplicitOps, 0, ImplicitOps, ImplicitOps,
-	0, 0, Group | Group4, Group | Group5,
+	ImplicitOps, ImplicitOps, Group | Group4, Group | Group5,
 };
 
 static u16 twobyte_table[256] = {
@@ -1755,6 +1755,14 @@ special_insn:
 		ctxt->eflags |= X86_EFLAGS_IF;
 		c->dst.type = OP_NONE;	/* Disable writeback. */
 		break;
+	case 0xfc: /* cld */
+		ctxt->eflags &= ~EFLG_DF;
+		c->dst.type = OP_NONE;	/* Disable writeback. */
+		break;
+	case 0xfd: /* std */
+		ctxt->eflags |= EFLG_DF;
+		c->dst.type = OP_NONE;	/* Disable writeback. */
+		break;
 	case 0xfe ... 0xff:	/* Grp4/Grp5 */
 		rc = emulate_grp45(ctxt, ops);
 		if (rc != 0)
-- 
1.5.4.3

Re: [PATCH] x86 emulator: Add std and cld instructions (opcodes 0xfc-0xfd)

[Avi Kivity]

Mohammed Gamal wrote:
> This adds the std and cld instructions to the emulator.
>
> Encountered while running the BIOS with the invalid guest
> state emulation patch.
>   

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function