From: Avi Kivity <avi@qumranet.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, joro@8bytes.org, anthony@codemonkey.ws
Subject: Re: [PATCH 2/9] Clean up VINTR setting
Date: Mon, 01 Sep 2008 16:13:01 +0300 [thread overview]
Message-ID: <48BBEA5D.20508@qumranet.com> (raw)
In-Reply-To: <1220270281-15720-3-git-send-email-agraf@suse.de>
Alexander Graf wrote:
> The current VINTR intercept setters don't look clean to me. To make
> the code easier to read and enable the possibilty to trap on a VINTR
> set, this uses a helper function to set the VINTR intercept.
>
> +static void svm_set_vintr(struct vcpu_svm *svm, bool on)
> +{
> + if (on) {
> + svm->vmcb->control.intercept |= 1ULL << INTERCEPT_VINTR;
> + } else {
> + svm->vmcb->control.intercept &= ~(1ULL << INTERCEPT_VINTR);
> + }
> +}
> +
>
svm_set_vintr() + svm_clear_vintr() would be even clearer IMO.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-09-01 13:13 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 11:57 [PATCH 0/9] [RFC] Add support for nested SVM (kernel) Alexander Graf
2008-09-01 11:57 ` [PATCH 1/9] Add CPUID feature flag for SVM Alexander Graf
2008-09-01 11:57 ` [PATCH 2/9] Clean up VINTR setting Alexander Graf
2008-09-01 11:57 ` [PATCH 3/9] Implement GIF, clgi and stgi Alexander Graf
2008-09-01 11:57 ` [PATCH 4/9] Add helper functions for nested SVM Alexander Graf
2008-09-01 11:57 ` [PATCH 5/9] Allow setting the SVME bit Alexander Graf
2008-09-01 11:57 ` [PATCH 6/9] Implement hsave Alexander Graf
2008-09-01 11:57 ` [PATCH 7/9] Add VMLOAD and VMSAVE handlers Alexander Graf
2008-09-01 11:58 ` [PATCH 8/9] Add VMRUN handler Alexander Graf
2008-09-01 11:58 ` [PATCH 9/9] Add VMEXIT handler and intercepts Alexander Graf
2008-09-01 13:58 ` Avi Kivity
2008-09-02 16:15 ` Alexander Graf
2008-09-03 9:23 ` Avi Kivity
2008-09-03 9:33 ` Alexander Graf
2008-09-03 9:47 ` Avi Kivity
2008-09-03 11:55 ` Alexander Graf
2008-09-01 13:41 ` [PATCH 8/9] Add VMRUN handler Avi Kivity
2008-09-02 15:38 ` Alexander Graf
2008-09-01 13:27 ` [PATCH 7/9] Add VMLOAD and VMSAVE handlers Avi Kivity
2008-09-01 14:14 ` Alexander Graf
2008-09-01 14:27 ` Avi Kivity
2008-09-01 14:49 ` Alexander Graf
2008-09-01 13:15 ` [PATCH 6/9] Implement hsave Avi Kivity
2008-09-01 14:11 ` Alexander Graf
2008-09-01 14:26 ` Avi Kivity
2008-09-01 13:21 ` Avi Kivity
2008-09-01 13:14 ` [PATCH 5/9] Allow setting the SVME bit Avi Kivity
2008-09-01 13:11 ` [PATCH 3/9] Implement GIF, clgi and stgi Avi Kivity
2008-09-01 14:02 ` Alexander Graf
2008-09-01 14:25 ` Avi Kivity
2008-09-01 15:37 ` Alexander Graf
2008-09-01 16:05 ` Avi Kivity
2008-09-01 16:13 ` Alexander Graf
2008-09-01 16:17 ` Avi Kivity
2008-09-01 16:40 ` Alexander Graf
2008-09-02 9:15 ` Avi Kivity
2008-09-01 13:13 ` Avi Kivity [this message]
2008-09-01 12:09 ` [PATCH 0/9] [RFC] Add support for nested SVM (kernel) Avi Kivity
2008-09-01 12:21 ` Joerg Roedel
2008-09-01 13:41 ` Daniel P. Berrange
2008-09-01 14:17 ` Alexander Graf
2008-09-01 14:22 ` Avi Kivity
2008-09-01 14:47 ` Alexander Graf
2008-09-01 14:57 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BBEA5D.20508@qumranet.com \
--to=avi@qumranet.com \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox