From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH 2/9] Clean up VINTR setting
Date: Mon, 01 Sep 2008 16:13:01 +0300
Message-ID: <48BBEA5D.20508@qumranet.com>
References: <1220270281-15720-1-git-send-email-agraf@suse.de> <1220270281-15720-2-git-send-email-agraf@suse.de> <1220270281-15720-3-git-send-email-agraf@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, joro@8bytes.org, anthony@codemonkey.ws
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:16443 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750831AbYIANNG (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 1 Sep 2008 09:13:06 -0400
In-Reply-To: <1220270281-15720-3-git-send-email-agraf@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Alexander Graf wrote:
> The current VINTR intercept setters don't look clean to me. To make
> the code easier to read and enable the possibilty to trap on a VINTR
> set, this uses a helper function to set the VINTR intercept.
>
> +static void svm_set_vintr(struct vcpu_svm *svm, bool on)
> +{
> +	if (on) {
> +		svm->vmcb->control.intercept |= 1ULL << INTERCEPT_VINTR;
> +	} else {
> +		svm->vmcb->control.intercept &= ~(1ULL << INTERCEPT_VINTR);
> +	}
> +}
> +
>   


svm_set_vintr() + svm_clear_vintr() would be even clearer IMO.

-- 
error compiling committee.c: too many arguments to function