From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/9] Implement GIF, clgi and stgi Date: Mon, 01 Sep 2008 17:25:05 +0300 Message-ID: <48BBFB41.8090004@qumranet.com> References: <1220270281-15720-1-git-send-email-agraf@suse.de> <1220270281-15720-2-git-send-email-agraf@suse.de> <1220270281-15720-3-git-send-email-agraf@suse.de> <1220270281-15720-4-git-send-email-agraf@suse.de> <48BBEA06.8090206@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, joro@8bytes.org, anthony@codemonkey.ws To: Alexander Graf Return-path: Received: from il.qumranet.com ([212.179.150.194]:35339 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750876AbYIAOZG (ORCPT ); Mon, 1 Sep 2008 10:25:06 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: >>> + >>> + u32 hflags; >>> }; >>> >> >> bool gif : 1; >> >> (or even >> >> bool gif;)? > > It's not visible in the patches I sent, but I did use the hflags for a > VMLOAD+VMRUN+VMSAVE aggregation hack. It's still somewhat flacky wrt > save/restore though, so I didn't send it. Hflags might be useful > nevertheless though. You mean code patching? >> >> Need save/restore support as well. Can be in a different patch, though. > > It might be a good idea to share hflags with qemu. I implemented the > GIF there already. Nothing prevents a similar format, though of course qemu is free to evolve, and anything in the kvm userspace interface is cast in stone. For the userspace interface, a __u32 is better than a bool and certainly better than bitfields. I was only suggesting bool for the internal representation. -- error compiling committee.c: too many arguments to function