Re: [PATCH 7/9] Add VMLOAD and VMSAVE handlers

[Avi Kivity <avi@qumranet.com>]

Alexander Graf wrote:
>
> On Sep 1, 2008, at 3:27 PM, Avi Kivity wrote:
>
>> Alexander Graf wrote:
>>> This implements the VMLOAD and VMSAVE instructions, that usually 
>>> surround
>>> the VMRUN instructions. Both instructions load / restore the same 
>>> elements,
>>> so we only need to implement them once.
>>>
>>> +static int nested_svm_vmloadsave(struct vmcb *from_vmcb, struct 
>>> vmcb *to_vmcb)
>>> +{
>>> +    memcpy(&to_vmcb->save.fs, &from_vmcb->save.fs, sizeof(struct 
>>> vmcb_seg));
>>> +    memcpy(&to_vmcb->save.gs, &from_vmcb->save.gs, sizeof(struct 
>>> vmcb_seg));
>>> +    memcpy(&to_vmcb->save.tr, &from_vmcb->save.tr, sizeof(struct 
>>> vmcb_seg));
>>> +    memcpy(&to_vmcb->save.ldtr, &from_vmcb->save.ldtr,
>>> +           sizeof(struct vmcb_seg));
>>>
>>
>> You can use simple assignment here.
>
> Uh ... like to_vmcb->save.fs = from_vmcb->save.fs; ? That works?

Welcome to 1983 (or whenever this was introduced) :)

>>
>> Don't we need to check that svm is enabled in the guest as well (and 
>> inject #UD if not)?
>
> The EFER_SVME check happens in nested_svm_do. This way all SVM 
> operations get the check without code duplication.

But the cpl check is not done?  Sad.


-- 
error compiling committee.c: too many arguments to function