From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/9] Implement GIF, clgi and stgi Date: Mon, 01 Sep 2008 19:05:47 +0300 Message-ID: <48BC12DB.5020204@qumranet.com> References: <1220270281-15720-1-git-send-email-agraf@suse.de> <1220270281-15720-2-git-send-email-agraf@suse.de> <1220270281-15720-3-git-send-email-agraf@suse.de> <1220270281-15720-4-git-send-email-agraf@suse.de> <48BBEA06.8090206@qumranet.com> <48BBFB41.8090004@qumranet.com> <7318388C-B414-424F-9A3E-5A9433D2A192@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM list , Joerg Roedel , Anthony Liguori To: Alexander Graf Return-path: Received: from il.qumranet.com ([212.179.150.194]:53980 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751859AbYIAQFt (ORCPT ); Mon, 1 Sep 2008 12:05:49 -0400 In-Reply-To: <7318388C-B414-424F-9A3E-5A9433D2A192@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: >>> It's not visible in the patches I sent, but I did use the hflags for >>> a VMLOAD+VMRUN+VMSAVE aggregation hack. It's still somewhat flacky >>> wrt save/restore though, so I didn't send it. Hflags might be useful >>> nevertheless though. >> >> You mean code patching? > > Yes. That's always fun. > > How exactly would you like to see the userspace bridge implemented? I > thought it might be good to put hflags in the x86 arch struct and just > have it transferred in get_sregs and set_sregs. I don't know if I > break any old userspace doing that though... We can't change struct kvm_sregs, since the structure size is encoded in the ioctl number. We need a new struct and new ioctls. The same was done for mpstate, for example. There's more info needed, btw. Whether the guest is in guest mode or host mode; what the current vmcs is; the value of eflags.if at the time vmrun was executed; and probably more. -- error compiling committee.c: too many arguments to function