From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/9] Implement GIF, clgi and stgi Date: Mon, 01 Sep 2008 19:17:08 +0300 Message-ID: <48BC1584.4020404@qumranet.com> References: <1220270281-15720-1-git-send-email-agraf@suse.de> <1220270281-15720-2-git-send-email-agraf@suse.de> <1220270281-15720-3-git-send-email-agraf@suse.de> <1220270281-15720-4-git-send-email-agraf@suse.de> <48BBEA06.8090206@qumranet.com> <48BBFB41.8090004@qumranet.com> <7318388C-B414-424F-9A3E-5A9433D2A192@suse.de> <48BC12DB.5020204@qumranet.com> <9444E915-41DE-4266-B810-3E5EE370D1D5@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM list , Joerg Roedel , Anthony Liguori To: Alexander Graf Return-path: Received: from il.qumranet.com ([212.179.150.194]:55992 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752216AbYIAQRJ (ORCPT ); Mon, 1 Sep 2008 12:17:09 -0400 In-Reply-To: <9444E915-41DE-4266-B810-3E5EE370D1D5@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: >> >> We can't change struct kvm_sregs, since the structure size is encoded >> in the ioctl number. We need a new struct and new ioctls. The same >> was done for mpstate, for example. > > Urks - doesn't sounds fast to me. > It's only for save/restore, not in any fast path. >> >> >> There's more info needed, btw. Whether the guest is in guest mode or >> host mode; what the current vmcs is; the value of eflags.if at the >> time vmrun was executed; and probably more. > > Do we really want to support storing the state when within the Level2 > VM? Can't we just #VMEXIT as soon as we switch to userspace or so? > That would probably simplify things a lot. > Great idea. What do we give as the exit reason? -- error compiling committee.c: too many arguments to function