From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Fix up pxe boot Date: Tue, 02 Sep 2008 11:39:13 +0300 Message-ID: <48BCFBB1.4090109@qumranet.com> References: <1220303503-19413-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, aliguori@us.ibm.com, apevec@redhat.com, chrisw@sous-sol.org, Eduardo Habkost To: Glauber Costa Return-path: Received: from il.qumranet.com ([212.179.150.194]:51828 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751359AbYIBIjO (ORCPT ); Tue, 2 Sep 2008 04:39:14 -0400 In-Reply-To: <1220303503-19413-1-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c > index 0b5fdc0..433aa3f 100644 > --- a/target-i386/op_helper.c > +++ b/target-i386/op_helper.c > @@ -600,7 +600,7 @@ do {\ > #define PUSHL(ssp, sp, sp_mask, val)\ > {\ > sp -= 4;\ > - stl_kernel((ssp) + (sp & (sp_mask)), (val));\ > + stl_kernel((uint32_t)((ssp) + (sp & (sp_mask))), (uint32_t)(val));\ > } > Surly it is better to push this into the underlying virtual->physical translation functions, so it applies everywhere? btw, the cast is wrong for x86-64, so it must be qualified for 32-bit operating modes. -- error compiling committee.c: too many arguments to function