public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] KVM: remove unnecessary remote tlb flush
@ 2008-09-01 18:13 Joerg Roedel
  2008-09-02  8:52 ` Avi Kivity
  0 siblings, 1 reply; 2+ messages in thread
From: Joerg Roedel @ 2008-09-01 18:13 UTC (permalink / raw)
  To: avi; +Cc: kvm, Joerg Roedel

The remote tlb flush in kvm_mmu_page_unlink_children() is not necessary because
this function is only called in kvm_mmu_zap_page() which does the flush itself
afterwards.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kvm/mmu.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index f4ab99f..0cbd5b4 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -980,7 +980,6 @@ static void kvm_mmu_page_unlink_children(struct kvm *kvm,
 				rmap_remove(kvm, &pt[i]);
 			pt[i] = shadow_trap_nonpresent_pte;
 		}
-		kvm_flush_remote_tlbs(kvm);
 		return;
 	}
 
-- 
1.5.3.7



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] KVM: remove unnecessary remote tlb flush
  2008-09-01 18:13 [PATCH] KVM: remove unnecessary remote tlb flush Joerg Roedel
@ 2008-09-02  8:52 ` Avi Kivity
  0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2008-09-02  8:52 UTC (permalink / raw)
  To: Joerg Roedel; +Cc: kvm

Joerg Roedel wrote:
> The remote tlb flush in kvm_mmu_page_unlink_children() is not necessary because
> this function is only called in kvm_mmu_zap_page() which does the flush itself
> afterwards.
>   

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-02  8:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-01 18:13 [PATCH] KVM: remove unnecessary remote tlb flush Joerg Roedel
2008-09-02  8:52 ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox