public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Avi Kivity <avi@qumranet.com>,
	kvm@vger.kernel.org, joro@8bytes.org, anthony@codemonkey.ws
Subject: Re: [PATCH 2/2] Allow the SVM CPUID bit in a VM
Date: Wed, 03 Sep 2008 09:55:36 +0200	[thread overview]
Message-ID: <48BE42F8.3040902@redhat.com> (raw)
In-Reply-To: <484561CE-F0E6-45E9-BBF0-7DBDB8571873@suse.de>

  Hi,

> On a sidenote I'm really not fond of the userspace CPUID capability
> restrictions in the first place. Shouldn't this all be determined in the
> kernel module? It doesn't make since IMHO to restrict NX usage from
> userspace. The kernel module knows best what it's capable of.

I think cpuid handling will be a quite interesting when it comes to
merging qemu and kvm.  Doing it completely in the kernel isn't going to
work.  There are several reasons why you might want to change the cpuid
presented to the guest.

First, you might want to mask out cpuid bits not supported by all
machines in your pool, for migration compatibility.

Second, you might want to present a specific CPU to the guest (like qemu
-cpu pentium).  At least as close as possible, of course there are some
restrictions.  I think even if you mask out the sse cpuid bit sse
instructions will actually work.  Also having a virtual intel cpu on amd
and visa versa probably isn't going to work unless we'll fall back to
the emulator for the missing instructions.

Third, there is the hypervisor cpuid range (0x40000000+).  That one
needs to be configurable by userspace as well.

cheers,
  Gerd

  parent reply	other threads:[~2008-09-03  7:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01 11:59 [PATCH 0/2] [RFC] Add support for nested SVM (userspace) Alexander Graf
2008-09-01 11:59 ` [PATCH 1/2] Add SVM CPUID feature define for backwards compatibility Alexander Graf
2008-09-01 11:59   ` [PATCH 2/2] Allow the SVM CPUID bit in a VM Alexander Graf
2008-09-01 14:00     ` Avi Kivity
2008-09-02 17:42       ` Alexander Graf
2008-09-02 17:53         ` Alexander Graf
2008-09-02 19:36           ` Itamar Heim
2008-09-03  7:55           ` Gerd Hoffmann [this message]
2008-09-03  8:04             ` Alexander Graf
2008-09-03  9:19               ` Avi Kivity
2008-09-03  9:13         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BE42F8.3040902@redhat.com \
    --to=kraxel@redhat.com \
    --cc=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=avi@qumranet.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox