* [patch] qemu compile warning
@ 2008-09-05 14:05 Jes Sorensen
2008-09-07 6:30 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Jes Sorensen @ 2008-09-05 14:05 UTC (permalink / raw)
To: Avi Kivity, kvm
[-- Attachment #1: Type: text/plain, Size: 113 bytes --]
Hi,
This one is more of a generic qemu nit, do you want to take it or should
I send it elsewhere?
Cheers,
Jes
[-- Attachment #2: 0102-qemu-fix-signness.patch --]
[-- Type: text/plain, Size: 837 bytes --]
Fix type of nb_sectors to match parameter of bdrv_get_geometry().
Signed-off-by: Jes Sorensen <jes@sgi.com>
---
qemu/block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: kvm-userspace.git/qemu/block.c
===================================================================
--- kvm-userspace.git.orig/qemu/block.c
+++ kvm-userspace.git/qemu/block.c
@@ -771,7 +771,7 @@
int ret, i, heads, sectors, cylinders;
struct partition *p;
uint32_t nr_sects;
- int64_t nb_sectors;
+ uint64_t nb_sectors;
buf = qemu_memalign(512, 512);
if (buf == NULL)
@@ -819,7 +819,7 @@
{
int translation, lba_detected = 0;
int cylinders, heads, secs;
- int64_t nb_sectors;
+ uint64_t nb_sectors;
/* if a geometry hint is available, use it */
bdrv_get_geometry(bs, &nb_sectors);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] qemu compile warning
2008-09-05 14:05 [patch] qemu compile warning Jes Sorensen
@ 2008-09-07 6:30 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2008-09-07 6:30 UTC (permalink / raw)
To: Jes Sorensen; +Cc: kvm
Jes Sorensen wrote:
> Hi,
>
> This one is more of a generic qemu nit, do you want to take it or should
> I send it elsewhere?
>
Nest to post it on qemu-devel@, so everyone benefits.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-07 6:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-05 14:05 [patch] qemu compile warning Jes Sorensen
2008-09-07 6:30 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox