From: Avi Kivity <avi@qumranet.com>
To: Mohammed Gamal <m.gamal005@gmail.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] x86 emulator: Add in/out instructions (opcodes 0xe4-0xe7, 0xec-0xef)
Date: Sun, 07 Sep 2008 10:27:06 +0300 [thread overview]
Message-ID: <48C3824A.9000907@qumranet.com> (raw)
In-Reply-To: <20080906142229.GB8095@mohd-laptop>
Mohammed Gamal wrote:
> The patch adds in/out instructions to the x86 emulator.
>
> The instruction was encountered while running the BIOS while using
> the invalid guest state emulation patch.
>
>
Applied, thanks.
> @@ -1252,6 +1255,8 @@ x86_emulate_insn(struct x86_emulate_ctxt *ctxt, struct x86_emulate_ops *ops)
> u64 msr_data;
> unsigned long saved_eip = 0;
> struct decode_cache *c = &ctxt->decode;
> + unsigned int port;
> + int io_direction;
> int rc = 0;
>
> /* Shadow copy of register state. Committed on successful emulation.
>
I renamed io_direction to io_dir_in as it isn't immediately clear what 0
and 1 mean with the original name.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-09-07 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-06 14:22 [PATCH] x86 emulator: Add in/out instructions (opcodes 0xe4-0xe7, 0xec-0xef) Mohammed Gamal
2008-09-07 7:27 ` Avi Kivity [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-08-04 19:57 [PATCH] x86 emulator: Add in/out instructions, opcodes (0xe4-0xe7, 0xec-0xef) Mohammed Gamal
2008-08-11 11:45 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C3824A.9000907@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox